redmatrix
fd8e6f3130
typo
2015-07-19 21:04:02 -07:00
redmatrix
4299ae65a4
abook clone sync - change logic to also unset existing cross-project flags besides just setting them
2015-07-16 18:07:23 -07:00
redmatrix
c3dbacfb88
don't including rating stuff from cloned abooks
2015-07-16 17:53:59 -07:00
redmatrix
b9fd8b4614
Merge branch 'master' of https://github.com/redmatrix/redmatrix
...
Conflicts:
include/zot.php
2015-07-15 18:41:50 -07:00
redmatrix
7db515b77c
fix for empty recip array resulting from a mangled xchan
2015-07-15 18:31:37 -07:00
redmatrix
7f6e4d5f4a
more clone sync issues across projects
2015-07-15 18:21:04 -07:00
redmatrix
95cf1668de
Merge branch 'master' of https://github.com/redmatrix/redmatrix
2015-07-15 18:15:25 -07:00
redmatrix
59b67d52e6
clone sync fixes across red/hz
2015-07-15 18:14:19 -07:00
redmatrix
e8f19c1e15
Merge branch 'master' of https://github.com/redmatrix/redmatrix
...
Conflicts:
mod/connedit.php
2015-07-14 17:10:13 -07:00
redmatrix
a5989b0f31
coverup and ignore the illegal string offset message that some sites have been reporting. This does not fix it. A fix would be to examine the data that has been received and find out why it is mangled and trace this back to where it was mangled.
2015-07-14 16:54:16 -07:00
redmatrix
dad4ac6c89
incorrect value for hubloc_deleted in zot_get_hublocs() query
2015-07-07 16:06:34 -07:00
redmatrix
90a31f4ad5
Merge branch 'master' of https://github.com/redmatrix/redmatrix
...
Conflicts:
include/zot.php
2015-07-02 22:00:15 -07:00
redmatrix
1a5898bf80
sync abook entries from redmatrix
...
Merge branch 'master' of https://github.com/redmatrix/redmatrix
Conflicts:
include/items.php
2015-07-02 21:58:28 -07:00
redmatrix
065a50c920
a few clone sync fixes as well as some work on hubzilla clone sync back to redmatrix
2015-07-02 21:55:36 -07:00
redmatrix
63f2e9b412
Merge branch 'master' of https://github.com/redmatrix/redmatrix
...
Conflicts:
include/zot.php
mod/connedit.php
util/messages.po
2015-06-28 22:33:13 -07:00
redmatrix
de13497333
no this isn't it. well ok, it's part of it, but not the important part. it's still pretty cool.
2015-06-28 21:16:56 -07:00
redmatrix
1a0655f34e
more work on mail flags
2015-06-23 21:01:59 -07:00
redmatrix
cb76fb8b9b
item flag fixes discovered after a few merges
2015-06-23 19:45:39 -07:00
redmatrix
859a2ac8ef
DB changes for some channel flags
2015-06-15 17:28:52 -07:00
redmatrix
be0459a98b
convert the abook fields
2015-06-14 21:08:00 -07:00
redmatrix
b381ec5734
Merge branch 'master' of https://github.com/redmatrix/redmatrix
...
Conflicts:
mod/impel.php
2015-05-27 19:27:38 -07:00
redmatrix
9a0264f5d2
some work on issue #329
2015-05-25 19:17:35 -07:00
redmatrix
3763f74a10
Merge branch 'master' of https://github.com/redmatrix/redmatrix
...
Conflicts:
include/items.php
include/text.php
mod/item.php
view/nl/messages.po
2015-05-20 20:49:06 -07:00
redmatrix
c10a4ca9c7
re-arrange the html cache a bit
2015-05-20 20:28:16 -07:00
redmatrix
62df06b3d6
cloning abook entries was broken in several ways if the target xchan wasn't available on the clone site. This should make it less broken.
2015-05-20 20:20:35 -07:00
redmatrix
a6cb90c81c
Merge branch 'master' into tres
...
Conflicts:
include/Import/refimport.php
include/activities.php
include/attach.php
include/event.php
include/externals.php
include/identity.php
include/items.php
include/notifier.php
include/photos.php
include/taxonomy.php
include/zot.php
mod/channel.php
mod/connedit.php
mod/events.php
mod/item.php
mod/like.php
mod/manage.php
mod/mood.php
mod/ping.php
mod/poke.php
mod/subthread.php
mod/tagger.php
mod/thing.php
2015-05-14 18:02:29 -07:00
redmatrix
25b599a4bd
convert ITEM_WALL from bitfield to standalone
2015-05-06 21:03:33 -07:00
redmatrix
a3c37f1458
first pass name change
2015-05-05 03:56:10 -07:00
friendica
6679734135
Merge branch 'master' into tres
...
Conflicts:
include/Contact.php
include/ItemObject.php
include/api.php
include/attach.php
include/diaspora.php
include/dir_fns.php
include/enotify.php
include/event.php
include/expire.php
include/items.php
include/notifier.php
include/notify.php
include/photos.php
include/taxonomy.php
include/text.php
include/widgets.php
include/zot.php
mod/admin.php
mod/channel.php
mod/dirsearch.php
mod/display.php
mod/editwebpage.php
mod/events.php
mod/home.php
mod/item.php
mod/manage.php
mod/mood.php
mod/network.php
mod/page.php
mod/photos.php
mod/ping.php
mod/post.php
mod/thing.php
mod/viewsrc.php
view/css/mod_events.css
2015-04-23 19:49:41 -07:00
Klaus Weidenbach
fdd6508019
Some documentation and whitespaces at line endings.
2015-04-10 00:28:23 +02:00
Klaus Weidenbach
d0361582b0
Correcting reported Doxygen syntax warnings.
...
Fixed wrong Doxygen syntax and add some of the available FIXME to
Doxygen documentation.
Updated Doxygen configuration to add also all capital letter tags.
Adding some more Doxygen documentation.
2015-03-29 22:23:00 +02:00
friendica
b1fd6c53a5
tweaks to directory registrations which don't seem to be happening, also downgrade any directory that claims to be a primary directory for RED_GLOBAL.
2015-03-19 15:56:30 -07:00
Michael Johnston
4e98a70e66
add missing %d for abook_closeness
2015-03-11 20:56:40 -04:00
friendica
54a9fb1774
diaspora's spammy permission model seems to have leaked through our firehose. Don't let it.
2015-03-10 12:22:22 -07:00
friendica
b5683bfac4
change default affinity (abook_closeness) to 80 for all new connections going forward (was 99). This way it can be adjusted down later without requiring you to change all your existing connections upward (since your existing connections are likely all sitting at 99 at the moment). The default setting is also configurable with a pconfig system.new_abook_closeness
2015-03-08 14:11:38 -07:00
friendica
99e4d2362c
I'm going to use the site_update timestamp to indicate whenever we successfully connect with a site. This way we can mark hubs dead on non-directory servers; but we have to wait before implementing this until we have a history of site_update being updated.
2015-03-03 15:54:38 -08:00
friendica
85f79990af
don't let a zot-finger bring a dead hub back to life unless it's the site we're currently talking to.
2015-03-03 15:22:24 -08:00
zottel
e4a2e353d8
make public delivery to contacts or any connections work again
...
$hash wasn't defined in this case
2015-03-02 11:05:03 +01:00
friendica
4162dfe43f
Merge https://github.com/friendica/red into pending_merge
2015-02-26 14:21:26 -08:00
friendica
09f80270de
loop breaker
2015-02-26 14:20:43 -08:00
Habeas Codice
82bb216952
more fake null shenanigans
2015-02-26 08:23:02 -08:00
Habeas Codice
f55e210120
Revert "more fake null shenanigans"
...
This reverts commit b57010e3da
.
2015-02-26 08:22:15 -08:00
Habeas Codice
b57010e3da
more fake null shenanigans
2015-02-26 08:20:29 -08:00
friendica
b32841e2dd
Found the cause of the delete looping, and I can prevent it going forward. The issue remains what to do about comments which are already in the DB and have ITEM_ORIGIN incorrectly set. We can't exactly reset them because the "original" context has been lost. (Sorry but couldn't resist an insider pun that none of you will be able to follow anyway). Read the comments.
2015-02-25 15:27:33 -08:00
friendica
1a071ea4f0
call post_local hooks prior to storing a post that is going to be sourced. There are some fields in the actual stored item that may change when we start the second delivery chain so a few plugins may not deal with these items correctly. Since we only source public items these effects will be slight.
2015-02-25 03:16:43 -08:00
friendica
2a2cc309ce
solve some (hopefully most) missing delivery issues
2015-02-25 01:39:45 -08:00
friendica
d29de912b4
public_recips cleanup
2015-02-23 16:27:12 -08:00
Habeas Codice
ffd47e6b95
catch negative ages
...
nix extra var
2015-02-20 19:48:51 -08:00
zottel
d0fe0b5d5f
fix parens mismatch from last commit
2015-02-18 11:48:05 +01:00
zottel
9d745cd072
also deliver public posts to channels with channel_w_stream = PERMS_AUTHED
2015-02-18 11:44:43 +01:00
Habeas Codice
d9d029470f
Merge branch 'master' of https://github.com/friendica/red
2015-02-16 15:13:31 -08:00
Habeas Codice
ca8e221018
normalize age data
...
mysql has type tinyint(3) which probably turns into a 24-bit value, but
postgres uses 3-digit decimal as its constraint (probably what the mysql
schema was intended to do). either that or mysql silently truncates while
postgres respects the constraint. Either way, bad data gets in unchecked, now
it's checked.
2015-02-16 15:09:43 -08:00
friendica
1c4b919980
force site_url to be lowercase when stored. Otherwise rating hubs on postgres could get real messy.
2015-02-15 23:45:22 -08:00
friendica
7bb2e25ea0
missing param
2015-02-13 13:04:31 -08:00
friendica
c62d605608
well that was certainly fun. And the reason why likes and other acitivity deletions weren't propagating. Hopefully this is the last reason and there aren't more lurking further down the chain.
2015-02-11 16:11:21 -08:00
friendica
8c061f143f
more efficient processing of response activities, plus a proof of concept fix for the problem of receiving a delete notification before we actually get the item which we're supposed to delete.
2015-02-11 15:26:35 -08:00
friendica
4b348d2489
Merge branch 'master' into tres
...
Conflicts:
view/css/mod_events.css
view/theme/redbasic/css/style.css
2015-02-05 19:38:43 -08:00
Habeas Codice
9ed23f9081
Merge branch 'master' of https://github.com/friendica/red
2015-02-05 09:15:39 -08:00
Habeas Codice
88488fdfbb
escape dates
2015-02-05 09:15:26 -08:00
friendica
de79bb89fc
Merge branch 'master' into pocorate
2015-02-03 16:03:58 -08:00
friendica
3f50313862
garbage in garbage out
2015-02-03 16:03:05 -08:00
friendica
1807db6cb0
send rating information to directories
2015-02-02 20:13:07 -08:00
friendica
e6a5f78003
Merge branch 'master' into tres
...
Conflicts:
include/zot.php
2015-01-31 00:50:20 -08:00
friendica
340212d77e
sync_locations() toggle DB flag functions were broken - result of postgres changes. Split these into seperate set and reset blocks.
2015-01-30 15:01:10 -08:00
friendica
ab0706521e
let zot_refresh continue without a primary hub if one cannot be found. also weekly doc updates
2015-01-30 13:45:28 -08:00
friendica
912be23e16
Merge branch 'master' into tres
...
Conflicts:
include/group.php
include/text.php
mod/acl.php
mod/channel.php
mod/connections.php
mod/display.php
mod/group.php
mod/item.php
mod/locs.php
mod/network.php
mod/photos.php
mod/ping.php
mod/starred.php
mod/viewsrc.php
2015-01-29 15:09:35 -08:00
friendica
ff68ea6087
more message restrict conversions
2015-01-29 14:51:41 -08:00
friendica
a496036066
local_user => local_channel
2015-01-28 20:56:04 -08:00
friendica
6c7269be94
add yet another firehose check
2015-01-28 01:13:32 -08:00
friendica
9feb300f47
more minor tweaks to the route mismatch algorithm after watching it all day.
2015-01-28 01:06:56 -08:00
friendica
a2cdd1499c
Merge branch 'master' into tres
...
Conflicts:
include/socgraph.php
2015-01-27 20:00:43 -08:00
friendica
0bfbe6d61d
sql typo
2015-01-27 19:58:43 -08:00
friendica
85b359e25c
ignore route mismatches on firehose posts to the sys channel. Use whatever parent route we have. By definition we aren't going to have permission issues with these things.
2015-01-27 17:53:19 -08:00
friendica
21f85b32ec
we need to actually ask for the id from the DB if we want to use it.
2015-01-27 17:46:16 -08:00
friendica
2f4ef7660c
improved route mismatch detection. We will be less strict about the absolute route matching and only look at the last hop before it got to us - which is ultimately all we should care about (since that sender controls the thread permissions). Route mismatches seem to occur somewhat frequently from yamkote (for unknown reasons), and the logging has been improved a bit so it should provide some slightly more useful debugging info in case it still happens going forward. Oh, also we'll set the parent on comments when we store the initial post (item_store()) and only go back and set the parent for top-level posts. This should reduce the number of comments with missing parents on shared hosts, but may increase the number of missing threads. Probably worthwhile to do a query occasionally for parent = 0 and see how we're doing and how many have shared host related delivery issues.
2015-01-27 15:47:24 -08:00
friendica
fc62d7e577
handle an incoming directory rating message
2015-01-26 19:43:39 -08:00
friendica
ac594183c6
Merge branch 'master' into tres and add some work on the item_deleted flag refactor
...
Conflicts:
include/attach.php
include/onedirsync.php
include/zot.php
mod/locs.php
2015-01-26 18:27:03 -08:00
Habeas Codice
1d6aead325
remove superfluous group by
...
this gets called from a zot post_post dealing with a specific messageid and hubloc_hash combination. grouping by site
doesn't make sense here and it gets grouped when pulled back out elsewhere anyway
2015-01-24 22:07:53 -08:00
friendica
e46eba1258
heavy lifting converting item flag bits
2015-01-22 17:41:16 -08:00
friendica
76fe9dc702
zot_finger second arg is optional but function declaration didn't specify this - causes issue with check_upstream_directory
2015-01-21 20:08:10 -08:00
friendica
29436081a8
slow progress removing bitfields on item table
2015-01-21 16:06:25 -08:00
friendica
51848c6190
working through the xchan table to remove bitfields, mostly complete except for updating the updater
2015-01-20 19:33:19 -08:00
friendica
ee3eee425c
that should take care of the bitfields in hubloc
2015-01-20 16:13:18 -08:00
friendica
6f11f20992
first cut at unpacking bitfields in hubloc, fixed hubloc_error and hubloc_deleted
2015-01-20 15:35:42 -08:00
friendica
10102ac2ac
connection clone issues
2015-01-10 14:59:10 -08:00
friendica
fbe0610ce9
don't update locally deleted items
2015-01-06 15:44:23 -08:00
friendica
452d275b5e
don't import to sys channel from self-censored authors
2014-12-12 00:26:07 -08:00
friendica
8e4e56b566
can't reset public to false because it may have been passed in as true and this would be wrong and cause even more subtle bugs. Reset to whatever value was passed in.
2014-12-01 18:59:38 -08:00
Thomas Willingham
def10df816
Somewhat subtle process_delivery() bug - $public was not being reset if a sys
...
channel is reached but then the loop iterated over another channel.
2014-12-01 19:09:50 +00:00
friendica
18cae8a78c
change logging of some troublesome or noisy bits so we can figure out what is really going on
2014-11-19 19:22:22 -08:00
friendica
7fec939c23
couple of fixes:
...
- significantly increase the content availability on the discover channel
- fix the button group on the blog/list mode which made the border on a single comment button a bit wonky
2014-11-19 14:41:24 -08:00
friendica
4893e64c1e
there's still a permission issue delivering a public post directly to the sys channel (on the local system), but this puts the local sys channel in the public delivery chain and fixes an issue with unseen counts showing on the discover page (where you can't do anything about it).
2014-11-19 00:56:05 -08:00
friendica
efcbcd6f88
add sys channel to public recips if scope public
2014-11-18 20:34:47 -08:00
friendica
b5da015789
put timeout code in place but don't turn it on.
2014-11-13 15:34:35 -08:00
Habeas Codice
ac27db22c1
Merge remote-tracking branch 'upstream/master'
...
Conflicts:
boot.php
include/dba/dba_driver.php
include/diaspora.php
include/follow.php
include/session.php
include/zot.php
mod/photos.php
mod/ping.php
2014-11-13 13:06:31 -08:00
Habeas Codice
1a5a5c7edb
PostgreSQL support initial commit
...
There were 11 main types of changes:
- UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but
it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just
copied from Friendica. All of these instances, the LIMIT 1 was simply removed.
- Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit
integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice
to boot). Proper explicit boolean conversions were added. New queries should use proper conventions.
- MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_
func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There
were no true toggles (XOR). New queries should refrain from using XOR when not necessary.
- There are several fields which the schema has marked as NOT NULL, but the inserts don't specify
them. The reason this works is because mysql totally ignores the constraint and adds an empty text
default automatically. Again, non-compliant, obviously. In these cases a default of empty text was
added.
- Several statements rely on a non-standard MySQL feature
(http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html ). These queries can all be rewritten
to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run
a zillion times faster, even on MySQL.
- A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG,
UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_
- INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes
around the value -- assist functions added in the dba_
- NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such
thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are
handled in Zot/item packets automagically by quoting all dates with dbescdate().
- char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the
code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works
better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype
for all text fields in the postgres schema. varchar was used in a couple of places where it actually
seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code
actually validates data, new bugs might come out from under the rug.
- postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted.
bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function
was added to handle this transparently.
- postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax.
Statements were updated to be standard.
These changes require corresponding changes in the coding standards. Please review those before
adding any code going forward.
Still on my TODO list:
- remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting
- Rewrite search queries for better results (both MySQL and Postgres)
2014-11-13 12:21:58 -08:00
friendica
5619902776
indicate public forums in directory results (there will be some [possibly considerable] lag time before existing forums are correctly tagged).
2014-11-10 17:44:02 -08:00
friendica
6209465233
add public forum identification to libzot. No attempt is made to identify other types of forums or weird custom channel permissions. If the channel is auto-accept and taggable, it's a public forum.
2014-11-10 15:21:04 -08:00
zottel
1f35d9432f
don't overwrite $x (contains import_xchan result) with role permissions
2014-11-06 17:24:05 +01:00
friendica
d5d6158973
ok heads up - potentially destabilising change. I've tried to sort out all the default connection permissions for those who don't have a predefined (or therefore have a "custom") permissions role. Unfortunately this includes most people that were using this software more than a month ago. The real changes are that the SELF address book entry no longer holds "auto-permissions" but instead holds your "default permissions" (if you have a pre-defined role, the defaults will be pulled from the role table).
...
The auto permissions have moved to a pconfig (uid.system.autoperms). A DB update will move these settings into their new homes.
What used to be the "Auto-permissions settings" page is now the "default permissions settings" page and a checkbox therein decides whether or not to apply the permissions automatically. A link to this page will only be shown when you have the "custom" role selected.
With luck nobody will notice anything wrong. But at least for the next few days, please review permissions that have been assigned to new connections (either automatically or manually) and make sure they make sense (e.g. they aren't "nothing"). You still need to take action when seeing a message "permissions have changed but not yet submitted" as we always let you review and perhaps adjust the settings _before_ a connection is established (unless you have autoperms turned on).
2014-11-04 17:11:02 -08:00