Commit graph

717 commits

Author SHA1 Message Date
redmatrix
cef77ce5bb the xchan_query wasn't fully optimised as we were comparing quoted and unquoted strings when looking for duplicates 2016-06-22 19:22:59 -07:00
redmatrix
63423c8ee1 make sure the optimisations are reliable 2016-06-20 20:56:58 -07:00
redmatrix
ed16660867 code optimisation 2016-06-20 20:34:19 -07:00
redmatrix
2793086c0d 1. string update, 2. pretty print json blobs 2016-06-17 14:58:03 -07:00
redmatrix
a2a87fec54 code comments 2016-06-15 22:36:00 -07:00
redmatrix
1dc35db1fe ignore case in language names and add 'js' as an alias for 'javascript' 2016-06-15 20:25:19 -07:00
redmatrix
854c23a751 This was the reason for the large line widths - an extra linefeed after each li element 2016-06-15 19:59:30 -07:00
redmatrix
fa48de33c2 provide syntax based [colour] highlighting on code blocks for popular languages. I'm not happy with the line height on the list elements but couldn't see where this was defaulted. This uses the syntax [code=xxx]some code snippet[/code], where xxx represents a code/language style - with about 18 builtins. 2016-06-15 19:44:15 -07:00
redmatrix
1ff9abe1b4 missing iconfig conversion 2016-06-13 21:16:36 -07:00
redmatrix
1e68d4fb75 deprecate the item_id table - replace with iconfig. A possibly useful function in the iconfig class would be a search which takes a service id and type and uid, matches against an item and returns the iid. That could save a bit of code duplication. 2016-06-13 19:58:24 -07:00
redmatrix
dd6718c2cd provide a hover class for smiley emojis which renders them slightly larger on compatible devices when you single them out for inspection 2016-06-04 18:10:42 -07:00
redmatrix
bf438f67e1 the :tone variants are messed up, remove them 2016-06-04 17:13:55 -07:00
redmatrix
81f6511d34 return of the project smilie 2016-06-04 17:09:37 -07:00
redmatrix
a6012af00d For emojis in posts, extend smilies and save a lot of duplication of effort 2016-06-04 17:06:12 -07:00
redmatrix
624f4641e2 missed an object -> obj conversion in prepare_body 2016-06-03 15:09:58 -07:00
redmatrix
f9075e2a2f some initial emoji reaction work 2016-06-02 18:42:51 -07:00
redmatrix
a9d7acda27 the rest of the schema updates - WARNING: some third party plugins may fail; e.g. embedphotos and chess. $item['object'] is now $item['obj'] and $photo['type'] is $photo['mimetype'], $photo['scale'] is $photo['imgscale'] and $photo['data'] is now $photo['content']. There are a number of other changes, but these are the ones noted to cause issues with third-party plugins. The project plugins have been updated. Please note any new issues as this effort touched a lot of code in a lot of files. 2016-06-01 21:48:54 -07:00
redmatrix
b1259876bf more db column renames 2016-05-31 21:45:33 -07:00
redmatrix
61304d80d2 track down some issues from the application logs 2016-05-26 18:45:47 -07:00
redmatrix
80f2ba640e code cleanup 2016-05-24 20:49:23 -07:00
redmatrix
516c43ba15 more work associated with DBA and index.php shuffle 2016-05-24 17:54:45 -07:00
redmatrix
84ba6393ad relocate index and db 2016-05-24 16:36:55 -07:00
redmatrix
de006771c7 renamed include files identity.php (channel.php) and Contact.php (connections.php) 2016-05-22 16:54:30 -07:00
redmatrix
f4da365abd move template stuff to zotlabs/render 2016-05-20 19:11:14 -07:00
redmatrix
b2f0d2d085 cleanup proc_run after messing it up with debugging yesterday 2016-05-20 17:44:26 -07:00
redmatrix
32ad8bbaac Ensure that channels can't be created with DAV reserved paths as a redress. Sabre mentions in several places that trying to change these paths to other strings; while possible - is unsupported and likely to cause problems. So for now, we're stuck with 'principals', 'addressbooks', and 'calendars'. If you already have these redresses on your site, you're basically buggered. 2016-05-11 17:18:17 -07:00
redmatrix
2a14c71128 convert media embed functions that deal with rewriting specific corporate services to addon hooks 2016-05-08 19:12:52 -07:00
redmatrix
7101bbedcb objectify comanche 2016-05-05 23:07:35 -07:00
redmatrix
a10fe5f13e a couple of bugfixes from earlier checkins and implementation of source tags 2016-05-01 22:45:38 -07:00
redmatrix
cd518625bf some much needed work on oembed security 2016-05-01 19:19:17 -07:00
redmatrix
84d93cca6e Merge branch 'dev' of https://github.com/redmatrix/hubzilla into dev_merge 2016-04-30 15:02:45 -07:00
Treer
8f16e9ad33 update icon names in include/ 2016-05-01 04:39:57 +10:00
redmatrix
4c47d22f4b trim engr_units string slight improvement to avoid subtle bugs 2016-04-29 23:47:13 -07:00
redmatrix
bb96f44861 allow engineering units (e.g. 400M, 1G) as service class limits 2016-04-28 21:02:27 -07:00
Mario Vavti
3446e68ac2 move spoiler= and quote= bbcode handling from prepare_body() to bbcode() and add open tag to bbco_autocomplete 2016-04-26 11:41:08 +02:00
redmatrix
d62f490814 Setup was horked after this commit and I couldn't easily make it right so reverting - will try again at a future date
Revert "remove global db variable"

This reverts commit c3b0c0f32a.
2016-04-25 20:12:36 -07:00
redmatrix
c3b0c0f32a remove global db variable 2016-04-25 16:55:33 -07:00
redmatrix
861f5232d3 more work on file sync to clones, 60-70% test coverage, mostly working but many changes made during testing which themselves have not yet been tested 2016-04-06 19:56:38 -07:00
redmatrix
29363a185d file sync work 2016-04-06 18:07:29 -07:00
redmatrix
9abd95fad3 static App 2016-03-31 16:06:03 -07:00
redmatrix
1cd3b41825 deprecate $a->get_baseurl() 2016-03-30 22:13:24 -07:00
redmatrix
6a6dbec033 issue #319 - NOTE: this does not fix the issue, it only reports it and continues. We need to examine any logger statements that contain 'stack:' as a result of reporting this issue and find and fix the original problem - which is that set_pconfig is being called without a valid $uid. I'm worried that since we will now continue on without throwing a PHP error that nobody will ever notice or find the problem that is causing this. 2016-03-30 16:33:23 -07:00
Mario Vavti
776bc51172 fix link to photo album and make sure that small photos are not overwritten by body text. 2016-02-26 15:21:14 +01:00
redmatrix
f1564b4cff retry the move of AccessList to composer format (one or more third-party plugins will likely break as a result) 2016-02-21 16:49:49 -08:00
redmatrix
18208fab84 poke basic config setting 2016-02-04 11:58:56 -08:00
redmatrix
7d7ef5ac4e add a fixme 2016-01-21 18:42:44 -08:00
Mario Vavti
b711c050db make contact block look widget alike 2016-01-21 11:48:10 +01:00
redmatrix
caf3a69d99 yearly license update 2015-12-31 13:25:23 -08:00
redmatrix
2cf4ac26fd log API improvements and queue optimisation for singleton networks 2015-12-31 12:26:41 -08:00
redmatrix
6db6fef29f spelling 2015-12-25 14:56:06 -08:00
redmatrix
f121b74bec enhance whitespace 2015-12-15 15:17:10 -08:00
redmatrix
2924b9182e revise the photo activity a bit so that we always have a valid activity body. Several network connectors can get empty posts or posts that don't contain any reference whatsoever to the actual photo. Since this can cause duplicate images on our own site, just provide the activity summary and any included body text to the activity by default. Provide a function to enhance this activity with an actual photo which can be applied on demand for any network connectors that desire it. Otherwise they'll just get a link to the photo in the activity statement - which is better than an empty post. Have applied this "add actual photo to the post" function to both Diaspora and RSS feeds. Also provide the album as the activity target. 2015-12-15 15:01:54 -08:00
Mario Vavti
056db37c66 beautify event item code 2015-11-26 22:14:20 +01:00
Mario Vavti
c7cbd41c16 first iteration on the event item 2015-11-26 12:26:27 +01:00
redmatrix
37368bda65 change _newwin to _blank because the window named _newwin may be hard to find if you have lots of windows/tabs open. 2015-11-20 12:49:38 -08:00
redmatrix
301072a86c issue #85, community tags and file tags lost during edits. This required splitting off communitytags as a separate tag type and is not backward compatible. Community tags on older posts or those federated from redmatrix clones will not be preserved during edits. 2015-11-20 00:15:48 -08:00
redmatrix
c7b2ec8bba allow plugins to also log to a different named logfile and also alter the log message 2015-11-15 19:40:01 -08:00
redmatrix
fff30b1c3d permission issues editing wall-to-wall posts 2015-11-15 19:36:17 -08:00
redmatrix
888bf76e4b allow pdl content 2015-11-12 17:47:38 -08:00
ken restivo
9c240de303 Add unit tests for valid email function. 2015-11-08 14:37:48 -08:00
Mario Vavti
5920a96da7 make attachments appear in a dropdown in wall-item-tools-left 2015-10-31 00:38:01 +01:00
redmatrix
06ec5424c7 restrict sslify to img tags by default - set config system.sslify_everything if you want to proxy media files also. 2015-10-28 16:58:13 -07:00
Mario Vavti
911fd6c654 improve photo item object - we now provide the infos for all available photo sizes 2015-10-25 18:01:44 +01:00
Mario Vavti
5395b173aa implement the new anchor target behaviour 2015-10-22 12:09:19 +02:00
Mario Vavti
735f9c7a45 define $photo 2015-10-22 11:37:34 +02:00
Mario Vavti
6f8d29ad80 move photo object stuff from itemObject to prepare_body() so we can do more stuff with it 2015-10-22 10:52:10 +02:00
redmatrix
bab73edcef extened the earlier fix 2015-10-19 16:50:53 -07:00
redmatrix
9b3662e5ad issues with "the Register" feed 2015-10-18 16:29:09 -07:00
Mario Vavti
d40a087ec2 really fix label name 2015-10-15 16:07:13 +02:00
Mario Vavti
138c14d43f wrong logic 2015-10-15 15:48:13 +02:00
Mario Vavti
dc6a594277 fix label name 2015-10-15 15:41:08 +02:00
Mario Vavti
2848f5dab4 Merge branch 'master' of https://github.com/redmatrix/hubzilla 2015-10-15 09:36:51 +02:00
redmatrix
de697a4267 issue #86 - like/dislike in photos not working 2015-10-14 14:16:16 -07:00
Mario Vavti
c8d8ae89d7 remove $item from $prep_arr - we probably do not need it 2015-10-14 22:46:40 +02:00
Mario Vavti
b4e83b6537 allow photo-items to appear full width if large photos feature is enabled. in prepare_body() split off mentions, tags, categories folders and attachments from body for easier theming. some other little fixes. 2015-10-14 22:14:19 +02:00
redmatrix
c76da2e77d functions to update urls in items when doing migrations 2015-10-06 20:30:49 -07:00
redmatrix
cd2b811555 move string files to hmessages.po and hstrings.php for hubzilla to avoid endless merge conflicts. 2015-09-26 23:44:30 -07:00
redmatrix
837b9224cc Merge https://github.com/redmatrix/redmatrix into pending_merge
Conflicts:
	doc/credits.bb
	mod/thing.php
2015-09-02 20:33:58 -07:00
redmatrix
d9a67d64b1 Update the credits 2015-09-02 18:04:22 -07:00
redmatrix
ca0bc2bb7b more work on AccessList integration 2015-08-27 22:20:30 -07:00
redmatrix
5786fd2221 extra encoding on mail titles 2015-08-20 01:12:35 -07:00
zottel
2bd05971ab fix observer tags for now (issue #17) 2015-07-16 08:28:37 +02:00
redmatrix
a497d8ee66 Merge branch 'master' of https://github.com/redmatrix/redmatrix
Conflicts:
	mod/editpost.php
	util/messages.po
	view/nl/messages.po
	view/nl/strings.php
2015-07-10 14:27:41 -07:00
Mario Vavti
efa55437d4 increase width of the aside area and make default profile image size 300x300 2015-07-09 13:59:16 +02:00
redmatrix
a3d7e8456a undo the disabling of browser_prefetch and for the time being revert the HTML cache until we can isolate all the zid and observer calls. Also get rid of youtube and vimeo bbcode tags which we should not be using any more. 2015-06-25 20:07:10 -07:00
redmatrix
1a0655f34e more work on mail flags 2015-06-23 21:01:59 -07:00
redmatrix
6aa159e2ac Merge branch 'master' of https://github.com/redmatrix/redmatrix 2015-06-18 19:15:01 -07:00
redmatrix
1a9c059062 issues with markdownify and escaped HTML 2015-06-18 16:35:40 -07:00
redmatrix
be0459a98b convert the abook fields 2015-06-14 21:08:00 -07:00
redmatrix
b381ec5734 Merge branch 'master' of https://github.com/redmatrix/redmatrix
Conflicts:
	mod/impel.php
2015-05-27 19:27:38 -07:00
Mario Vavti
3d79d4f577 define some custom attributes and html5 elements for htmlpurifier 2015-05-27 15:25:45 +02:00
redmatrix
3763f74a10 Merge branch 'master' of https://github.com/redmatrix/redmatrix
Conflicts:
	include/items.php
	include/text.php
	mod/item.php
	view/nl/messages.po
2015-05-20 20:49:06 -07:00
redmatrix
c10a4ca9c7 re-arrange the html cache a bit 2015-05-20 20:28:16 -07:00
redmatrix
6466774b6e PRIVACY: possible privacy leakage under a defined set of circumstances 2015-05-20 18:46:23 -07:00
redmatrix
507dfb9f85 add rot47 to the mix. This shouldn't affect the speed to any measurable degree. 2015-05-19 21:51:48 -07:00
redmatrix
77e2ef45f0 mail_obscure - AES-256 is way too slow, simplify. Ideally a substitution cipher would be adequate for our requirements. 2015-05-19 02:16:12 -07:00
redmatrix
a6cb90c81c Merge branch 'master' into tres
Conflicts:
	include/Import/refimport.php
	include/activities.php
	include/attach.php
	include/event.php
	include/externals.php
	include/identity.php
	include/items.php
	include/notifier.php
	include/photos.php
	include/taxonomy.php
	include/zot.php
	mod/channel.php
	mod/connedit.php
	mod/events.php
	mod/item.php
	mod/like.php
	mod/manage.php
	mod/mood.php
	mod/ping.php
	mod/poke.php
	mod/subthread.php
	mod/tagger.php
	mod/thing.php
2015-05-14 18:02:29 -07:00
redmatrix
018e702281 Merge branch 'master' of https://github.com/redmatrix/redmatrix
Conflicts:
	mod/mitem.php
	view/nl/strings.php
2015-05-12 19:00:54 -07:00
redmatrix
f2a0dac653 fix a couple of miscellaneous errors which showed up in the logs 2015-05-11 22:57:12 -07:00
redmatrix
e85593e970 Hopefully this will make item_cache the default 2015-05-06 21:43:15 -07:00
redmatrix
a3c37f1458 first pass name change 2015-05-05 03:56:10 -07:00
friendica
b467dc4f00 Merge branch 'master' into tres 2015-05-01 13:19:19 -07:00
friendica
e4fe068ed5 more performance work 2015-04-30 18:16:54 -07:00
friendica
097002910e just a test, please do not try to implement this as there are severe security issues 2015-04-30 17:52:34 -07:00
friendica
6679734135 Merge branch 'master' into tres
Conflicts:
	include/Contact.php
	include/ItemObject.php
	include/api.php
	include/attach.php
	include/diaspora.php
	include/dir_fns.php
	include/enotify.php
	include/event.php
	include/expire.php
	include/items.php
	include/notifier.php
	include/notify.php
	include/photos.php
	include/taxonomy.php
	include/text.php
	include/widgets.php
	include/zot.php
	mod/admin.php
	mod/channel.php
	mod/dirsearch.php
	mod/display.php
	mod/editwebpage.php
	mod/events.php
	mod/home.php
	mod/item.php
	mod/manage.php
	mod/mood.php
	mod/network.php
	mod/page.php
	mod/photos.php
	mod/ping.php
	mod/post.php
	mod/thing.php
	mod/viewsrc.php
	view/css/mod_events.css
2015-04-23 19:49:41 -07:00
friendica
01efda6850 api - unobscure mail 2015-04-19 13:41:12 -07:00
Mario Vavti
2001ad94bd dont suggest anything here it explains itself 2015-04-14 11:59:49 +02:00
Mario Vavti
bf2a97147e some more on webpages 2015-04-14 11:50:21 +02:00
Mario Vavti
8138373973 move style to style.css 2015-04-10 14:14:19 +02:00
Mario Vavti
5457b417f8 make r# work better with different font sizes 2015-04-10 14:01:40 +02:00
friendica
4fd80304a5 that didn't work out well - let's do this instead 2015-04-08 23:20:28 -07:00
friendica
4289c8adb2 fix selector when sys channel active 2015-04-08 23:12:39 -07:00
friendica
7bec4b313a system channel always has allow_code privileges 2015-04-08 23:05:36 -07:00
Klaus Weidenbach
754ac2cff7 Fix Design Tool navigation for sys channel.
Fix creating menu for sys channel.
2015-04-06 23:52:13 +02:00
Klaus Weidenbach
d0361582b0 Correcting reported Doxygen syntax warnings.
Fixed wrong Doxygen syntax and add some of the available FIXME to
Doxygen documentation.
Updated Doxygen configuration to add also all capital letter tags.
Adding some more Doxygen documentation.
2015-03-29 22:23:00 +02:00
friendica
e33da588bd comanche: move 'webpage' declaration to the first parser pass so it is set when content loads. 2015-03-25 15:32:49 -07:00
friendica
c024668cf2 catche edge case of tag "@abcdef +1", which tags the first entry in your abook, regardless of abcdef. This holds true for other similar patterns as well. 2015-03-24 02:36:45 -07:00
friendica
c2acab21d4 improve performance of the zotfeed queries 2015-03-23 19:56:10 -07:00
friendica
a2e3ca6fd8 add loadtime search to channel and fix it for home. display and search need further investigation 2015-03-21 16:46:28 -07:00
friendica
63683734a2 make the channel item query match recent changes to network item query (and some slightly older changes in display item query), and allow '@' in linkified urls. 2015-03-18 19:06:05 -07:00
friendica
178b768e3c openid cleanup 2015-03-16 17:08:50 -07:00
Klaus Weidenbach
124b17dcf4 Some cleanups.
Fixed dbesc_identifier(), but it is not used yet.
Corrected some other variable names and variable initialization before
using them.
2015-03-13 00:36:32 +01:00
friendica
11df605c2e support rel=me on channel "homepage" url 2015-02-24 00:45:03 -08:00
friendica
4b513d3322 issue #896 2015-02-12 19:22:07 -08:00
friendica
08b757a22c Merge branch 'master' into tres
Conflicts:
	mod/events.php
	view/css/mod_events.css
2015-02-08 20:57:37 -08:00
friendica
7edab47658 get_rel_link broken - also weekly doc updates 2015-02-06 02:07:10 -08:00
friendica
4b348d2489 Merge branch 'master' into tres
Conflicts:
	view/css/mod_events.css
	view/theme/redbasic/css/style.css
2015-02-05 19:38:43 -08:00
friendica
3f50313862 garbage in garbage out 2015-02-03 16:03:05 -08:00
friendica
043ff33e43 issue #889 private tags for forums no longer recognised after tag refactor a few weeks back. This solution is not optimal as it also leaves you in the privacy ACL in some cases and not in others but it restores the previous functionality 2015-02-02 14:59:01 -08:00
friendica
aafed50a0e Merge branch 'master' into tres 2015-02-01 20:30:47 -08:00
marijus
22ad8f413d add multipart/mixed to getIconFromType() 2015-02-01 12:48:25 +01:00
friendica
912be23e16 Merge branch 'master' into tres
Conflicts:
	include/group.php
	include/text.php
	mod/acl.php
	mod/channel.php
	mod/connections.php
	mod/display.php
	mod/group.php
	mod/item.php
	mod/locs.php
	mod/network.php
	mod/photos.php
	mod/ping.php
	mod/starred.php
	mod/viewsrc.php
2015-01-29 15:09:35 -08:00
friendica
ff68ea6087 more message restrict conversions 2015-01-29 14:51:41 -08:00
friendica
a496036066 local_user => local_channel 2015-01-28 20:56:04 -08:00
friendica
a2cdd1499c Merge branch 'master' into tres
Conflicts:
	include/socgraph.php
2015-01-27 20:00:43 -08:00
marijus
65aa6cf708 move userReadableSize() and getIconFromType() from /include/RedDAV/RedBrowser.php to include/text.php and add template for mod/sharedwithme 2015-01-27 19:00:16 +01:00
friendica
ac594183c6 Merge branch 'master' into tres and add some work on the item_deleted flag refactor
Conflicts:
	include/attach.php
	include/onedirsync.php
	include/zot.php
	mod/locs.php
2015-01-26 18:27:03 -08:00
Alexandre Hannud Abdo
2e783dbe79 Call sslify with an extra path element so files keep their names
The main motivation for this is when saving images one doesn't
need to inspect and manually input the file's actual name.

There might be other benefits, perhaps in automated downloads.
2015-01-25 02:08:59 -02:00
friendica
6e0e3b2433 more expanding item flags 2015-01-22 18:41:10 -08:00
friendica
51848c6190 working through the xchan table to remove bitfields, mostly complete except for updating the updater 2015-01-20 19:33:19 -08:00
friendica
ee3eee425c that should take care of the bitfields in hubloc 2015-01-20 16:13:18 -08:00
Stefan Parviainen
334d496bb1 Fix some issues with tagging. 2015-01-16 19:10:34 +01:00
friendica
d6ae124bbd ignore bbcode open tag (left bracket) in hash and mention tag regexes and turn it into a tag delimiter 2015-01-14 16:00:21 -08:00
friendica
dfdef0af0d provide a setting to control ALLOWCODE permissions at the channel level - it isn't always appropriate to apply this to all channels in an account. 2015-01-13 18:30:30 -08:00
Stefan Parviainen
93735df2c7 Allow tags in mail, many profile fields, and admin info 2015-01-13 17:54:40 +01:00
Stefan Parviainen
adc9564b5c Refactor mention code to make it more reusable 2015-01-12 20:01:07 +01:00
friendica
aa490a39bb include channel clones in PM deliveries (also some whitespace edits) 2015-01-08 16:02:15 -08:00
friendica
1cfff44535 lines reversed in handle_tag() 2015-01-06 13:42:55 -08:00
Stefan Parviainen
7bf7f8180d Revert "Revert "Language names via intl library.""
This reverts commit 4f35efa0ba.
2014-12-31 10:42:08 +01:00
RedMatrix
4f35efa0ba Revert "Language names via intl library." 2014-12-31 10:43:19 +11:00
Stefan Parviainen
9cab8ae58a Language names via intl library. Fixes #773 2014-12-30 20:29:31 +01:00
friendica
2b3cc585a2 fix double encoding of homepage in profile activity - not as straight-forward as it looked 2014-12-21 14:43:06 -08:00
Stefan Parviainen
fe80dbb3a7 Access list of smilies over JSON 2014-12-20 17:33:35 +01:00
friendica
0f0f12a453 allow a variety of latitude/longitude delimiters since nobody can agree on them. 2014-12-17 16:11:21 -08:00
friendica
cc0df5bc24 ability to generate arbitrary map with [ map=lat/lon] and also free form location using [ map]somewhere[/map] but the second one currently has no plugins available to generate it. 2014-12-17 14:12:19 -08:00
friendica
789e025eab Add [ map ] element to bbcode, no closing tag. Requires a map generator plugin (like openstreetmap which was just updated) and also requires that the author has browser location enabled. 2014-12-16 15:50:20 -08:00
Klaus Weidenbach
233903c844 Add security logger to RedDAV.
Some smaller clean ups whitepsaces and tabs, use PHP_EOL, Doxygen, etc.
2014-12-14 01:50:56 +01:00
Stefan Parviainen
62dabecf97 Show tags in other channels profile field to make it easier to navigate to the channels 2014-12-07 16:19:22 +01:00
Habeas Codice
b224f8056c new system config reserved_channels
prevents members from creating channels in a reserved list
2014-11-21 15:35:59 -08:00
Habeas Codice
ac27db22c1 Merge remote-tracking branch 'upstream/master'
Conflicts:
	boot.php
	include/dba/dba_driver.php
	include/diaspora.php
	include/follow.php
	include/session.php
	include/zot.php
	mod/photos.php
	mod/ping.php
2014-11-13 13:06:31 -08:00
Habeas Codice
1a5a5c7edb PostgreSQL support initial commit
There were 11 main types of changes:
- UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but
it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just
copied from Friendica. All of these instances, the LIMIT 1 was simply removed.
- Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit
integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice
to boot). Proper explicit boolean conversions were added. New queries should use proper conventions.
- MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_
func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There
were no true toggles (XOR). New queries should refrain from using XOR when not necessary.
- There are several fields which the schema has marked as NOT NULL, but the inserts don't specify
them. The reason this works is because mysql totally ignores the constraint and adds an empty text
default automatically. Again, non-compliant, obviously. In these cases a default of empty text was
added.
- Several statements rely on a non-standard MySQL feature
(http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten
to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run
a zillion times faster, even on MySQL.
- A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG,
UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_
- INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes
around the value -- assist functions added in the dba_
- NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such
thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are
handled in Zot/item packets automagically by quoting all dates with dbescdate().
- char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the
code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works
better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype
for all text fields in the postgres schema. varchar was used in a couple of places where it actually
seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code
actually validates data, new bugs might come out from under the rug.
- postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted.
bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function
was added to handle this transparently.
- postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax.
Statements were updated to be standard.

These changes require corresponding changes in the coding standards. Please review those before
adding any code going forward.

Still on my TODO list:
- remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting
- Rewrite search queries for better results (both MySQL and Postgres)
2014-11-13 12:21:58 -08:00
friendica
4b9ec6645b cleanup 2014-11-11 20:44:43 -08:00
friendica
b5af667985 slow progress on sys publishing, making sure all the data we need is in the places we need it but validate it anyway 2014-11-11 19:29:30 -08:00
friendica
570577a990 a couple of places where we need to look for a sys channel euid. 2014-11-11 18:05:50 -08:00
friendica
06e5d0798c and urlencode that. 2014-11-11 16:09:45 -08:00
friendica
09b09dedbc Most directory searches are POST. get_query_args() only handles GET so that had to be fixed or page 2 of directory search results wouldn't match the search. 2014-11-11 16:06:16 -08:00
friendica
e80c20d258 Don't recognise hashtags starting with #, e.g. ### 2014-10-15 17:55:20 -07:00
marijus
289f57f79e template for searchbox and some more work on saved searches 2014-10-08 12:36:26 +02:00
friendica
72ec78d027 trying to call mod/magic on rss resources - which have no hub 2014-09-22 23:49:12 -07:00
friendica
e8854bb19d better way to deal with effective_uid 2014-09-22 22:03:19 -07:00
friendica
e4e9098f39 prevent red#matrix smilie replacements from tripping over each other. 2014-09-08 21:36:33 -07:00
friendica
8cbeeb09da extra_query_args() restricted to $_GET only. $_REQUEST was adding cookies and this is undesired and potentially a security issue. 2014-09-06 03:11:07 -07:00
friendica
28b75b028d ajax work 2014-09-06 00:37:15 -07:00
friendica
01a5ac92a8 improved logging if you're using php54 or later 2014-09-04 23:13:46 -07:00
friendica
a63de472cf various rss fixes 2014-08-31 20:51:05 -07:00
Thomas Willingham
450434a690 Revert - see comments. 2014-08-26 20:13:27 +01:00
Thomas Willingham
cc2bef67dd HTML doesn't work without ACCOUNT_ROLE_ALLOWCODE, so don't offer it
as an option.
2014-08-26 19:09:00 +01:00
friendica
831714f0f0 profile edit - missing visibility and drop link on non-default profiles, re-arrange order of replacing red#matrix smilie so it works correctly, accept a post with body content of '0' which was interpreted by x() as nothing (was treated as integer). 2014-08-21 16:46:24 -07:00
friendica
b3d450626e provide an overt indication that a post/comment was edited. 2014-08-18 22:44:03 -07:00
friendica
de97073e13 don't subdue archived connections in viewconnections 2014-07-16 22:32:18 -07:00
friendica
98e85917bb subdue archived connections in group editor and don't show at all in contact_block() 2014-07-16 22:21:29 -07:00
friendica
17bd39fcd4 rename friendica_smarty 2014-07-13 23:00:03 -07:00
jeroenpraat
29aece3472 added A NAME/ID to whitelist in HTMLpurifier. That means we can now make vintage indexes in web pages. 2014-07-11 22:28:26 +00:00
friendica
8a84718163 for non-post items (e.g. photos, events, whatever) add mention tags explicitly to the output rendering since they may not be present in the post body. 2014-06-30 22:46:17 -07:00
friendica
33cf83175d use consistent capitalisation in the item actions menu 2014-05-29 21:34:08 -07:00
friendica
345f784f67 fix search to use in app 2014-05-22 21:24:41 -07:00
friendica
2fe8bae7a5 show hidden connections in contact block if and only if the observer is the profile owner 2014-05-08 17:08:34 -07:00
friendica
c36489a753 Unfortunate omission 2014-04-26 19:33:39 -07:00
friendica
9026ea649a better mapping of visible connections 2014-04-14 17:29:19 -07:00
friendica
dc1a529b63 remove extra tag logging 2014-04-12 23:57:19 -07:00
friendica
4fda10db2f don't match quote remnants 2014-04-12 17:04:54 -07:00
friendica
d7aaff459f let normal hashtags be quoted strings also 2014-04-12 16:58:19 -07:00
friendica
03753f463e convert /network saved search to bootstrap buttons 2014-04-07 16:25:35 -07:00
friendica
28b7eedc45 check_webbie (webbie validator) returning bad webbies 2014-04-06 19:59:00 -07:00
friendica
93f90040a1 community tags don't show up in the tagged posts because we removed the displayed list of hashtags at the bottom (which are usually redundant since hashtags are usually present in the message text). This brings them back, but only for tags which aren't currently present in the message body (e.g. community tags) 2014-03-31 17:03:07 -07:00
friendica
653d7df86d issue #378, failure to correctly link tags where one tag contains a substring of the other (depends on the order they are discovered). 2014-03-30 20:53:59 -07:00
friendica
ecb2e52a74 little fixes of hopefully nil significance 2014-03-16 20:34:21 -07:00
friendica
3cb179aff1 contact_block() not being shown to unauthenticated visitors - even if perms allow. Also separate the permissions logic for this function so that we can have a mini-profile widget and a separate contact_block widget instead of always lumping them together. We probably also should move contact_block() outside of include/text.php as it doesn't really belong there. Just not sure where it belongs - perhaps contact_widgets wouold be a good place. 2014-03-13 17:13:36 -07:00
friendica
7baeb45183 some anomolies found when viewing connections in various cases. 2014-03-02 19:40:59 -08:00
friendica
6ac81c9360 fix zrl bookmarks which broke with this checkin: c9192991c9
It was documented that:
  Issues: Currently the order of HTML parameters in the text is somewhat rigid and inflexible.
but as that was in a different function it was easy to overlook.
2014-02-18 19:47:13 -08:00
friendica
d6ab975b18 operation snakebite continued. openid now works for local accounts using the rmagic module and after storing your openid in pconfig. This is just an interesting but trivial (in the bigger scheme of things) side effect of snakebite. The snake hasn't even waken up yet. 2014-02-17 19:48:05 -08:00
friendica
ebd52368bb strip hard-wired zids from posted links as they will have the wrong identity when somebody tries to view the link 2014-02-16 14:13:26 -08:00
marijus
a606fc0ba3 add a sanitized style tag to bbcode 2014-02-05 14:34:25 +01:00
friendica
8a11c29413 make links in comments bookmark-able 2014-02-04 19:39:56 -08:00
friendica
9ce3dac479 some tagging fixes - including old bugs which were never reported 2014-02-03 19:54:32 -08:00
friendica
876f5d4de0 transmit, receive, and parse bookmarks 2014-02-03 19:38:15 -08:00
friendica
6c91580716 code cleanup - remove some unused functions 2014-02-03 02:21:06 -08:00
toclimb
ba6178bef3 More efficient smilie replacing 2014-02-02 14:52:00 +01:00
toclimb
4c28939488 Don't look for emoticons inside the matching angle brackets of HTML tags (seriously) 2014-01-29 23:56:05 +01:00
friendica
d79a2e3b55 undo pull request #287 2014-01-28 16:32:47 -08:00
toclimb
3cab53a7ef Don't look for text emoticons inside the matching angle brackets of a HTML tag 2014-01-29 00:43:54 +01:00
friendica
a78d9b973d simplify permalink selection logic 2014-01-09 16:23:58 -08:00
zottel
5d83855afd use plinks instead of llinks on network/ and channel/ pages, though not in
mode network-new (network/new and network/search)
2014-01-09 16:04:51 +01:00
friendica
66600ed2f8 try again 2013-12-25 04:06:26 -08:00
friendica
6c0a3f31bb didn't work 2013-12-25 02:48:59 -08:00
friendica
4ec569d6e7 sslify http links in media elements if you're on an https server 2013-12-25 02:45:22 -08:00
friendica
125543aded more comanche migration 2013-12-19 02:16:14 -08:00
friendica
94975f8d30 categories should already be html encoded - ensure this is the case but don't double encode 2013-12-13 12:30:44 -08:00
friendica
b3fe221b7f issue #240 - we were using htmlentities instead of htmlspecialchars in several places, and this was a bit greedy in the set of characters which were converted from utf-8 to HTML entities. Also brought mail attachments up to date so they are rendered identically to item attachments. 2013-12-11 23:13:36 -08:00
friendica
ed9f108722 comanchify the savedsearch widget 2013-12-09 21:20:55 -08:00
marijus
76d8501d67 saved search icon work and bugfixes for #tags not beeing deletable and save button showing if saved search is disabled 2013-12-10 00:32:49 +01:00
friendica
75ebf06131 some work on modularising the default profile photo so we can make them site selectable. Also red != friendica so we don't need all these friendica logos taking up space 2013-12-09 14:05:52 -08:00
friendica
04f61dd4a1 add icon_trnalsate 2013-12-04 21:10:03 -08:00
friendica
d9f67876dc refactor magic-auth 2013-12-02 15:15:02 -08:00
friendica
d1ab865ccf make the template processor (e.g. replace_macros) pluggable 2013-11-28 19:17:45 -08:00
tuscanhobbit
8619fc368d updated logo in readme and r# shorthand 2013-11-22 22:45:16 +01:00
friendica
d7ee552c57 Protocol: now set data['alg'] on all encapsulated encrypted packets, so that we can more easily retire 'aes256cbc' once it is no longer viable. 2013-11-20 15:20:12 -08:00
friendica
a6f37739c2 too much privacy on get_plink() which is left over from Friendica days 2013-11-10 14:15:57 -08:00
friendica
4b3db9b523 update smilies 2013-11-07 20:48:46 -08:00
friendica
c48da79adf link to source - if it's on the display page link to original source (probably on a different site). All other conversations link to 'llink' which is a local copy and may provide a richer possibility of interactions, especially if you're logged in locally and it's your own copy of the post. 2013-10-20 20:29:52 -07:00
friendica
9787872778 linkify post categories 2013-10-14 15:34:47 -07:00
friendica
4f2c056d6d template and icons for categories and "file as" 2013-10-14 04:49:28 -07:00
friendica
db42e4d2f9 attachment icons revisited 2013-10-13 21:14:04 -07:00
zottel
e6c93e4146 fix alt_pager to work if item count is higher than page['itemspage'] (threads) 2013-10-11 10:50:06 +02:00
friendica
3985aa07b4 more icon tweaks - this could be going on for some time; try to get icon code (and all theme stuff) out of main code and into templates, but on the short term provide both so nothing breaks. 2013-10-10 02:15:44 -07:00
friendica
7b6530fed5 add the auto form submit even though it doesn't seem to work. Will debug it later. 2013-10-01 20:10:09 -07:00
Thomas Willingham
3c42989fc4 Typo 2013-09-29 16:45:21 +01:00
Thomas Willingham
9212fd0ecc Issue #117 2013-09-29 16:40:15 +01:00
friendica
d4ea56a77e reduce susceptibility to bleichenberger attack 2013-09-24 05:20:29 -07:00
friendica
54abed8457 provide a "safe search" backend and allow for self-censorship using nsfw or adult profile keywords. Eventually the directories will be forced to mark adult profiles and sync this knowledge between them. At the moment there's no way to do an unsafe search, but we really just need a checkbox and pass the value through directory to dirsearch on the back end, and some will want this as a pconfig. 2013-09-19 19:50:13 -07:00
friendica
a78b76d393 more work on viewing obscured api posts 2013-09-16 22:51:39 -07:00
friendica
ab1c9dc9c9 add design tool menu to appropriate pages 2013-09-03 19:55:26 -07:00
friendica
615bf23733 add a layout selector 2013-09-02 20:25:33 -07:00
friendica
dfa2efcecf oh that's why 2013-09-02 16:37:54 -07:00
friendica
56e408f467 pass execflag - Working for preview but not yet executing on page render 2013-09-02 16:29:52 -07:00
friendica
7c775db9d6 fix webpage storage 2013-09-02 16:01:29 -07:00
friendica
f44274bfca allow a channel owner to define a default mimetype on webpages (otherwise default to "choose") - also fix the selector w/r/t php code. There is no ui for setting either at the moment, but for instance with wiki pages we probably don't want to have multiple choice of the mimetype. Keep it simple. 2013-09-02 13:31:59 -07:00
friendica
8b7757e033 webpage content-type -- needs cleaning up and a security check once all the important bits are in place. 2013-09-02 01:38:17 -07:00
friendica
d7a9db1088 important bits we need to allow php executable content. These must be explicitly allowed - but only if the account has ACCOUNT_ROLE_ALLOWCODE and *only* for web pages and profile fields. This content cannot be transmitted to other sites. 2013-08-11 16:56:06 -07:00
friendica
24b9799dca convert all stored json calls to json_decode_plus() 2013-08-06 03:54:49 -07:00
friendica
71347bb9e0 we've been storing json_encoded structures on disk in several places because it's a lot easier to parse than xml - but OMG do they get mangled - stored as single quoted strings when escaped as if double quoted. We need to use my new function json_decode_plus() wherever we need to parse one of these babies to make sure we get it right. Maybe we should've just used serialize(). 2013-08-06 03:29:57 -07:00
friendica
27b4127f30 pass item by reference so title can be altered 2013-08-01 19:18:05 -07:00
friendica
222fe08420 ensure that no unencrypted content leaks through item_store which is private - we typically do this in mod/item, but some functions
bypass mod/item to create private posts
2013-08-01 18:50:36 -07:00
friendica
d002ff668a encrypt private messages on disk - there are still a couple of places where the text is leaked in the logs during processing. 2013-07-28 21:04:03 -07:00
friendica
aa8bb99678 improve the red smiley 2013-07-28 18:45:27 -07:00
friendica
5a8cda632b remove double tags on search results, updates to install doco to get rid of Friendica name there and clarify Red requirements. 2013-07-09 22:48:34 -07:00
friendica
b86253c655 issue #65 2013-07-01 19:41:11 -07:00
friendica
e16d678aab relocate tagadelic to include/taxonomy 2013-06-21 15:15:07 -07:00
friendica
58ac92f4e1 bring back the body tag list - though it really belongs in the templates. It's difficult to debug community tags when you can't see any tags (except those the author typed in). 2013-06-20 20:34:00 -07:00
friendica
95d7514633 undefined activity_compare which broke notifications (should be activity_match) and revamp xchan_query as abook is optional and need not be present - if it isn't there we still need the xchan, but if it is there we need to make sure that it belongs to whichever channel owns the post 2013-06-20 15:55:20 -07:00
friendica
3dcf9a1df7 bug in commentable - ambiguous abook entry 2013-06-20 02:03:14 -07:00
friendica
3b1e5e5204 source code re-org, move taxonomy to separate include 2013-06-19 21:50:14 -07:00
friendica
28cd8594a7 implement 'can_comment_on_post()' which doesn't require a separate DB lookup per item. 2013-06-16 20:44:29 -07:00
friendica
0ef71dd4e2 This should get community tagging pretty close to working - deleting a community tag is left as a FIXME 2013-06-04 22:52:17 -07:00
friendica
b866cc26fa templatise alt_pager 2013-06-03 18:16:00 -07:00
Thomas Willingham
5e1a5a696b Typo, or somehow ended up with a missing line another way. 2013-05-29 04:30:04 +01:00
Thomas Willingham
af3fc75856 Add red smiley for the sake of consistency with Friendica's set. 2013-05-28 19:28:14 +01:00
friendica
08a4ffd663 convert most red photos to zmg 2013-05-28 04:50:16 -07:00
friendica
7a011a99c7 wrong attribution on likes of comments in email notifications. Let's also call the thing they liked a comment instead of a status 2013-05-28 01:40:27 -07:00
friendica
ad0c5e3c68 fix zidify_img_callback - wrong number of args 2013-05-27 19:50:29 -07:00
friendica
df32c93d56 zidify img links, delay notifier until actually published for time travelling posts 2013-05-27 05:27:35 -07:00
friendica
6a2e644a87 more progress on items_fetch (new name) 2013-05-23 18:50:27 -07:00
fabrixxm
31a21ac24c use smarty3 as default template engine. add pluggable template system 2013-05-08 03:51:38 -04:00
Thomas Willingham
6e2e8f101a Uncripple zids. 2013-04-16 05:52:10 +01:00
friendica
7e6890832b turn all Red links into zrls (not the old zrls, the new bbcode zrl which means we can zidify them) 2013-04-15 03:00:08 -07:00
friendica
e411a4bdc2 IMPORTANT: magic-auth protocol update, plus 'zrl' bbcode tag for the privacy-is-more-important-than-ease-of-use folks. 2013-04-14 20:41:58 -07:00
friendica
f5940b7ddb modify linkify to work correctly with Red mid's containing '@' 2013-04-08 16:58:52 -07:00
friendica
8148b7c32f update manage table and some documentation 2013-03-27 19:02:01 -07:00
friendica
ddf5bf8968 rename 'uri' (and parent_uri) to 'mid' (and parent_mid) since these no longer remotely resemble uri's and are actually message_id's. This change is potentially destabilising because it touches a lot of code and structure. But it has to get done and there's no better time than the present. 2013-03-21 18:25:41 -07:00
friendica
b3c699d49a support various and multiple content_types on the display side - still have some work to do on the posting side. 2013-03-21 16:14:08 -07:00
friendica
4cfbdfa6db cleanup affinity tool 2013-03-03 23:38:08 -08:00
friendica
596ed80adf hex2bin is a built-in function in PHP 5.4 2013-02-27 00:59:41 -08:00
friendica
48d2f7e07d get rid of str_getcsv legacy function since we now require php 5.3 2013-02-26 20:07:14 -08:00
friendica
c1e2f95484 doc update 2013-02-26 18:26:33 -08:00
friendica
ea3940c4b0 start formatting for Doxygen 2013-02-25 17:09:40 -08:00
friendica
488714290f global rename viewcontacts to viewconnections 2013-02-19 03:00:29 -08:00
friendica
2d6027150f viewcontacts update 2013-02-19 00:20:47 -08:00
friendica
55df911403 performance profiling - 95% of the time is spent in "conversation()" e.g. rendering and templates, even with the new theme engine. The time spent in the DB is miniscule. Will have to profile the bbcode processing and template engines individually to drill down further. 2013-02-09 02:46:50 -08:00
friendica
6a23ac9217 added 'dlogger()' which is intended as a low noise personal logger() facility for developers. See the source. 2013-02-05 20:39:19 -08:00
friendica
2a6abaf9d5 partial cleanup of mod/profile_photo - needs a LOT more 2013-02-05 20:14:19 -08:00
Oliver
4ee4dcf43d fix con"n"nections 2013-02-02 20:07:28 +01:00
friendica
344b8593a8 sort out the rest of the nasty stuff in the attachment/file api - time to move on to something else 2013-02-01 00:49:07 -08:00
friendica
132a5f0f96 add new magic links to activity translations 2013-01-25 04:30:03 -08:00
friendica
060716f172 make lockview work, bring back acl widget theming in redbasic 2013-01-20 18:05:29 -08:00
friendica
45be26dd81 more heavy lifting on API - though need to re-visit events and give them all message_ids from the origination site. 2013-01-19 22:21:00 -08:00
friendica
9725dcf41d distributed directory search from the navbar 2013-01-19 00:43:05 -08:00
Zach Prezkuta
c94c500cdc deal gracefully with non-existent files 2013-01-06 19:58:50 -07:00
Zach Prezkuta
a0d19ffb72 implement Smarty3 2013-01-06 15:57:11 -07:00
friendica
5894a7db48 tag cloud ported - except for putting into a template 2013-01-04 22:40:35 -08:00
friendica
0d623f716c import basic tag cloud functions - needs porting to this database schema and taxonomy infrastructure 2013-01-04 22:04:57 -08:00