sekretaerbaer/friendica-addons-sekb
1
0
Fork 0
forked from Friendica/friendica-addons
Code Pull requests Activity

Merge pull request #393 from annando/twitter-mirror-bug

Browse source 
Twitter: Mirrored retweets sometimes were empty
This commit is contained in:
Tobias Diekershoff 2016-12-13 09:37:19 +01:00 committed by GitHub
commit befda05c79
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
twitter/twitter.php
View file

@ -749,11 +749,12 @@ function twitter_do_mirrorpost($a, $uid, $post) {
$datarray["profile_uid"] = $uid; $datarray["profile_uid"] = $uid;
$datarray["extid"] = NETWORK_TWITTER; $datarray["extid"] = NETWORK_TWITTER;
$datarray['message_id'] = item_new_uri($a->get_hostname(), $uid, NETWORK_TWITTER.":".$post->id); $datarray['message_id'] = item_new_uri($a->get_hostname(), $uid, NETWORK_TWITTER.":".$post->id);
$datarray['object'] = json_encode($post);
$datarray["title"] = ""; $datarray["title"] = "";
if (is_object($post->retweeted_status)) { if (is_object($post->retweeted_status)) {
// We don't support nested shares, so we mustn't show quotes as shares on retweets // We don't support nested shares, so we mustn't show quotes as shares on retweets
$item = twitter_createpost($a, $uid, $post, array('id' => 0), false, false, true); $item = twitter_createpost($a, $uid, $post->retweeted_status, array('id' => 0), false, false, true);
$datarray['body'] = "\n".share_header($item['author-name'], $item['author-link'], $item['author-avatar'], "", $datarray['body'] = "\n".share_header($item['author-name'], $item['author-link'], $item['author-avatar'], "",
$item['created'], $item['plink']); $item['created'], $item['plink']);
@ -1363,6 +1364,7 @@ function twitter_createpost($a, $uid, $post, $self, $create_user, $only_existing
); );
if (count($r)) { if (count($r)) {
logger("Item with extid ".$postarray['uri']." found.", LOGGER_DEBUG);
return(array()); return(array());
} }
@ -1412,6 +1414,7 @@ function twitter_createpost($a, $uid, $post, $self, $create_user, $only_existing
$postarray['owner-link'] = $r[0]["url"]; $postarray['owner-link'] = $r[0]["url"];
$postarray['owner-avatar'] = $r[0]["photo"]; $postarray['owner-avatar'] = $r[0]["photo"];
} else { } else {
logger("No self contact for user ".$uid, LOGGER_DEBUG);
return(array()); return(array());
} }
} }
@ -1433,6 +1436,7 @@ function twitter_createpost($a, $uid, $post, $self, $create_user, $only_existing
if(($contactid == 0) AND !$only_existing_contact) { if(($contactid == 0) AND !$only_existing_contact) {
$contactid = $self['id']; $contactid = $self['id'];
} elseif ($contactid <= 0) { } elseif ($contactid <= 0) {
logger("Contact ID is zero or less than zero.", LOGGER_DEBUG);
return(array()); return(array());
} }