Roland Häder
346790cbbc
According to @annando and @MrPetovan, $emailcc is no item
field (column) and ( #5401 )
...
should be initialized empty (I did it above the `if()` block).
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-18 17:26:14 -04:00
Pierre Rudloff
6e1ed0b0d3
Fix tests ( #5400 )
...
* Avoid argc side-effects
* Fix undefined array keys in JITConfigAdapter::set()
* Avoid argv side effects in ApiTest
2018-07-18 16:30:55 -04:00
Jeroen De Meerleer
b265bf2ec3
Prettified the parameter layout of workerqueue ( #5397 )
...
* Prettified the parameter layout of workerqueue
* Updated to code standards :)
* Where did I go wrong?
2018-07-18 16:24:35 -04:00
Roland Häder
2c44437d40
Fixed E_NOTICE when no 'term' was provided ( #5391 )
...
* Fixed E_NOTICE when no 'term' was provided, maybe better encapsulate this whole
$_GET, $_POST and $_SESSION thing into a `Request` class?
Signed-off-by: Roland Häder <roland@mxchange.org>
* Rewrote to recommendation by @MrPetovan which results in really nicer code.
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-18 15:41:24 -04:00
Pierre Rudloff
b057906bed
Fix silent exit in ApiTest::testApiMediaUploadWithMedia() ( #5398 )
2018-07-18 15:36:51 -04:00
Tobias Diekershoff
9518145377
switch the Vagrant VM to the new config system ( #5396 )
2018-07-18 15:32:24 -04:00
Philipp
2d0446bd38
simplifying unittests ( #5395 )
...
* simplifying unittests
- use @requires instead class_exist
- define @small and @medium
* simplifying unittests
- removed unnecessary throwings
2018-07-18 15:04:18 -04:00
Michael Vogel
2fa6cc0000
Merge pull request #5394 from MrPetovan/bug/fix-config-set-return-value
...
Change (P)Config::set return value to bool
2018-07-18 11:07:10 +02:00
Michael Vogel
66a103e36a
Merge pull request #5295 from MrPetovan/task/4889-move-config-to-config
...
Move configuration to config/
2018-07-18 11:04:35 +02:00
Hypolite Petovan
0f7c7cebeb
Change (P)Config::set return value to bool
2018-07-18 02:32:35 -04:00
Hypolite Petovan
1b6727fb9c
Fix notice in Util\Network
2018-07-17 21:00:22 -04:00
Roland Häder
a41e49c84a
Fixes for E_NOTICE in mod/item.php ( #5393 )
...
* Fixes applied:
- `if (is_array($some_array))` is better code style than `if ($some_array)` as
the `if()` block really needs an array to be found
- same with `if ($some_id)`, maybe `if ($some_id > 0)` is a more proper check
- added missing field 'emailcc' to Item::ITEM_FIELDLIST
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes E_NOTICE of missing variable (PHP's lazyness again).
Signed-off-by: Roland Häder <roland@mxchange.org>
* Use !empty() to avoid accessing empty array.
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-17 18:18:42 -04:00
Roland Häder
fd8897851f
Fixes for OEmbed class ( #5392 )
...
* Fixes:
- stdClass is clearly an object of `\stdClass`, so let's import it and set it
as type-hint here
- if $o->type is not found, don't continue
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fix for a fix due to 02:51 a.m. (!) edits ...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-17 16:28:20 -04:00
Hypolite Petovan
050ad68b9f
Improve Console/Config display for array values
...
- Prevent setting a config key that is an array
2018-07-17 02:15:05 -04:00
Hypolite Petovan
d993c8584c
Add support for legacy $lang config in App->loadConfig
2018-07-17 02:05:52 -04:00
Hypolite Petovan
007ec92ae4
Remove exception for legacy config file in App->loadDatabase
2018-07-17 02:05:36 -04:00
Hypolite Petovan
7b8efcc23d
Fix config value type in MemcachedCacheDriver
...
- Remove default config values set in CacheDriverFactory
2018-07-17 02:05:06 -04:00
Hypolite Petovan
dfa461b3bc
Improve help/Config page
...
- Remove obsolete file-only config list
- Fix heading level
- Add transition instruction for $lang
- Add reference to config.ini.php, settings.ini.php and addon.ini.php
- Add link to help page in admin warning about legacy config file
2018-07-17 02:03:39 -04:00
Roland Häder
04b513ba95
Fixed E_NOTICE when 'title' is absent (uninitialized array key) ( #5390 )
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-17 01:13:22 -04:00
Hypolite Petovan
bad2774817
Separate default config values between file-only and admin settings
2018-07-16 19:38:19 -04:00
Hypolite Petovan
67dc08d120
Enforce systen.register_policy value type
2018-07-16 19:38:19 -04:00
Hypolite Petovan
9b01a23c9b
Code standards in App
2018-07-16 19:38:19 -04:00
Hypolite Petovan
b260ca4d1e
Fix typo in mod/admin
2018-07-16 19:38:19 -04:00
Hypolite Petovan
c207f6d597
Remove remaining references to Config::get in include/dba
2018-07-16 19:38:18 -04:00
Hypolite Petovan
763c66dd49
Improve console/config display
...
- Add visual distinction between get/set value
2018-07-16 19:38:18 -04:00
Hypolite Petovan
796eb1c874
Fix undefined index in mod/settings
2018-07-16 19:38:18 -04:00
Hypolite Petovan
3001951075
Move the addon-specific config in config/addon.ini.php
...
- Add sample addon.ini.php file
- Add config/addon.ini.php file to git ignore
2018-07-16 19:38:18 -04:00
Hypolite Petovan
e72ff9ee95
Fix missing use in mod/ping
2018-07-16 19:38:17 -04:00
Hypolite Petovan
b343987120
Fix segfault in PHP 5.6 parsing INI strings
...
- add documentation to generated local.ini.php file
2018-07-16 19:38:17 -04:00
Hypolite Petovan
c8d3067d0a
Fix JITConfigAdapter to retrieve non-db config.* values
2018-07-16 19:38:17 -04:00
Hypolite Petovan
bd04c03c9f
Fix urlpath determination on the root page
2018-07-16 19:38:17 -04:00
Hypolite Petovan
39767fb366
Fix undefined index notice messages in mod/install
2018-07-16 19:38:17 -04:00
Hypolite Petovan
0cbe3aa8e6
Remove global $db variable
2018-07-16 19:38:17 -04:00
Hypolite Petovan
820afa2284
Replace global $a with BaseObject::getApp()
2018-07-16 19:38:17 -04:00
Hypolite Petovan
d0780ccf7d
Replace global $lang with system.language
2018-07-16 19:38:17 -04:00
Hypolite Petovan
adacf421a6
Remove deprecated functions in include/text
2018-07-16 19:38:17 -04:00
Hypolite Petovan
4161908f43
Fix formatting in mod/help
2018-07-16 19:38:17 -04:00
Hypolite Petovan
627fa08a1b
Chasing a segfault in PHP 5.6 tests
2018-07-16 19:38:17 -04:00
Hypolite Petovan
5906c7e013
Remove api test pconfig debug
2018-07-16 19:38:17 -04:00
Hypolite Petovan
7b8410f5ef
Fix wrong mode for App since local conf file wasn't present
2018-07-16 19:38:17 -04:00
Hypolite Petovan
478b42e88f
Fix debug
2018-07-16 19:38:16 -04:00
Hypolite Petovan
6987129a00
Add yet more pconfig debug to testApiGetUserWithCustomFrioSchema
2018-07-16 19:38:16 -04:00
Hypolite Petovan
224765cdf5
Wrong table name
2018-07-16 19:38:16 -04:00
Hypolite Petovan
f8a90f3425
Add more api test debug
2018-07-16 19:38:16 -04:00
Hypolite Petovan
de0afd3b32
Add api test debug
2018-07-16 19:38:16 -04:00
Hypolite Petovan
4efcd47807
Put base test config in Yaml dataset
2018-07-16 19:38:16 -04:00
Hypolite Petovan
6b03ae92b8
Fix Memached config value format usage
2018-07-16 19:38:16 -04:00
Hypolite Petovan
8fe9a46ccf
Set system.hostname in test bootstrap
2018-07-16 19:38:16 -04:00
Hypolite Petovan
59c38d1b73
Move meaningful message inside Exception thrown in Cache tests
2018-07-16 19:38:16 -04:00
Hypolite Petovan
9396b05659
Revert using Config class in dba
2018-07-16 19:38:16 -04:00