Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2024-12-28 03:22:20 +00:00
Code Issues Projects Releases Packages Wiki Activity
21154 commits 3 branches 64 tags 241 MiB
Commit graph

2054 commits

Author SHA1 Message Date
Roland Häder
4d39164c1e [WIP] Rewrite to Proxy class: (#5507) 
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
  functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
  will do this for us
- renamed those proxy_*() functions to better names:
  + proxy_init()           -> Proxy::init()         (public)
  + proxy_url()            -> Proxy::proxifyUrl()   (public)
  + proxy_parse_html()     -> Proxy::proxifyHtml()  (public)
  + proxy_is_local_image() -> Proxy::isLocalImage() (private)
  + proxy_parse_query()    -> Proxy::parseQuery()   (private)
  + proxy_img_cb()         -> Proxy::replaceUrl()   (private)

* Ops, need to set $a here ...

* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule

* Ops, no need for own instance of $a when self::getApp() is around.

* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
  methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module

* No instances from utility classes

* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`

* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.

* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.

* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
 2018-07-30 22:06:22 -04:00
Roland Häder
bf87ad4fcf Fixed E_NOTICE in listing worker queue and new utilities class added (#5521) 
* Fixes for E_NOTICE in workqueue:
- introduced class `Friendica\Util\Arrays` which will hold static methods for
  handling arrays that cannot be done with PHP's functions, like implode() on
  multi-dimensional arrays
- rewrote old-school for() loop to foreach()

* Added intial unit test with some tests on empty delimiters and/or sinle and
multi-dim array.

* Added test for for 3-dimensional arrays, thanks to  nupplaphil's feedback.
 2018-07-30 21:24:26 -04:00
Michael Vogel
1eb8f04274 Fixing SQL error when receiving DFRN posts (#5527) 
* Some more notices

* Fixed nasty to find notice in DFRN and OStatus

* And more notices ...

* Yeah, some removed notices ... again ...

* Fixing bad SQL query
 2018-07-30 07:06:32 +02:00
Michael Vogel
a2cea16954 Some more notices (#5526) 
* Some more notices

* Fixed nasty to find notice in DFRN and OStatus

* And more notices ...

* Yeah, some removed notices ... again ...
 2018-07-30 06:41:20 +02:00
Roland Häder
650c3c18e1
Fixed fatal error about when returned 'body' field is empty: 
````
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Friendica\Protocol\PortableContact::discoverServer() must be of the type array, null given, called in /var/www/../src/Protocol/PortableContact.php on line 1664 and defined in /var/www/../src/Protocol/PortableContact.php:1765
Stack trace:
````
 2018-07-29 17:34:20 +02:00
Tobias Diekershoff
02d4b1098e
Merge pull request #5519 from annando/test-2 
Moved expiring of item content
 2018-07-29 11:45:50 +02:00
Michael
6add589c3f Removed some test logging 2018-07-29 04:38:14 +00:00
Michael
bc38420801 Some more notices removed 2018-07-29 04:04:23 +00:00
Michael
dc9b10fb09 Moved expiring of item content 2018-07-29 03:54:34 +00:00
Michael Vogel
489d3daa94 Trying to clean up a little bit more (#5517) 
* "post-type" replaces "bookmark" and "type"

* The permission set is now removed upon expiry

* Post update now stores the permission set

* We don't store the permissions in the item table anymore

* Postupdate now handles "postopts" as well

* "post-type" replaces "bookmark" and "type"

* "post-type" replaces "bookmark" and "type"

* "post-type" replaces "bookmark" and "type"

* The permission set is now removed upon expiry

* The permission set is now removed upon expiry

* We don't store the permissions in the item table anymore

* Postupdate now handles "postopts" as well

* Multiplicated update functions

* And some more duplicated functions ...

* Removed duplicate functions
 2018-07-28 16:04:56 -04:00
Michael Vogel
91db91d315 Fix for post update (#5513) 
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

* Postupdate now handles "postopts" as well

* Set deprecated fields to "null" if empty

* Postupdates are enabled again

* Fix for post update
 2018-07-28 13:12:35 -04:00
Michael Vogel
36d4516e7a Missing stuff in "develop"? (#5516) 
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

* Postupdate now handles "postopts" as well

* Set deprecated fields to "null" if empty

* Postupdates are enabled again

* "post-type" replaces "bookmark" and "type"

* The permission set is now stored

* The permission set is now removed upon expiry

* Postupdate now handles "postopts" as well
 2018-07-28 13:11:46 -04:00
Hypolite Petovan
0902ea508d
Fix parse error in Protocol\PortableContact (#5515) 2018-07-28 08:52:57 -04:00
Roland Häder
c30ac30f29 Possible fix for #5470 - json_decode() (#5511) 
* Possible fix for #5470:
- $data is not an object like stdClass but an array
- newer PHP versions doesn't allow cross-access like following:

  $object['foo'] = 123;
  $array->foo = 123;

- added type-hints for private methods for above cases
- used `if (empty($foo)) instead of just `if ($foo)` preventing some nasty
  E_NOTICE
- added some empty lines for better readability

* Rewrite:
- mixture of object/array was here, causing under newer PHP versions some E_NOTICE
- this has been now finally fixed by converting any `object` type to an
  associative `array`
- also changed `is_object()` to `is_array()`
 2018-07-28 01:35:27 -04:00
Roland Häder
4a22710b3b Moved global PAGE_* to Profile class (#5500) 
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class

* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class

* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes

* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*

* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`

* Ops, melting brain cells here ... :-/
 2018-07-27 19:25:57 -04:00
Michael Vogel
5f77e98d76 Postupdate is now working again (#5512) 
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

* Postupdate now handles "postopts" as well

* Set deprecated fields to "null" if empty

* Postupdates are enabled again
 2018-07-27 19:24:26 -04:00
Michael Vogel
1e83261a88
Merge pull request #5509 from friendica/revert-5506-fixes/portable-contact 
Revert "Possible fix for #5470 and empty() usage"
 2018-07-27 08:04:19 +02:00
Michael Vogel
82e3163e5e Revert "Possible fix for #5470: (#5506)" 
This reverts commit 1e20fd84f7.
 2018-07-27 08:02:41 +02:00
Roland Häder
592190892c Continued: (#5508) 
- `App` is now "imported" to avoid having \Friendica\App::* everywhere
 2018-07-26 22:27:28 -04:00
Roland Häder
1e20fd84f7 Possible fix for #5470: (#5506) 
- $data is not an object like stdClass but an array
- newer PHP versions doesn't allow cross-access like following:

  $object['foo'] = 123;
  $array->foo = 123;

- added type-hints for private methods for above cases
- used `if (empty($foo)) instead of just `if ($foo)` preventing some nasty
  E_NOTICE
- added some empty lines for better readability
 2018-07-26 18:27:12 -04:00
Michael Vogel
986106a8f7 Item storage: Permissions aren't stored in the items anymore (#5495) 
* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...
 2018-07-25 19:14:55 -04:00
Roland Häder
37253656e3 Moved CONTACT_* constants to Friendica\Model\Contact class, lesser in global namespace (#5490) 
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class

* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
 2018-07-24 22:53:46 -04:00
Michael Vogel
69af69d1a0 Fallback to Diaspora if DFRN transmission fails (#5487) 2018-07-24 14:12:09 -04:00
Michael Vogel
5a8654194a
Merge pull request #5452 from MrPetovan/bug/5443-fix-worker-notices 
Fix notices in OEmbed et al.
 2018-07-24 17:11:53 +02:00
Hypolite Petovan
6771522167 Reduce cache time for OEmbed error 2018-07-24 11:05:09 -04:00
Michael Vogel
be8b68aaaf Store guid and plink with event (#5485) 
* Store guid and plink with event

* One space too much
 2018-07-24 10:01:31 -04:00
Hypolite Petovan
b6e3da8443 Move addLanguageToItemArray call when body is ensured 2018-07-24 08:52:25 -04:00
Hypolite Petovan
df917251ff Fix undefined oembed properties 
- Add Object\OEmbed class
 2018-07-24 07:56:27 -04:00
Hypolite Petovan
adc47fc8ea Fix Undefined index: nurl in Protocol\PortableContact 2018-07-24 07:55:42 -04:00
Hypolite Petovan
41fd5bef13 Fix by reference notice in Protocol\PortableContact 2018-07-24 07:54:12 -04:00
Hypolite Petovan
4e9ba728c4 Fix undefined index body in Model\Item 2018-07-24 07:54:12 -04:00
Hypolite Petovan
d09ab35816 Fix getimagesizefromstring() read errors 2018-07-24 07:54:12 -04:00
Michael Vogel
ca2c316de0 Some removed notices when viewing events (#5483) 2018-07-24 07:51:50 -04:00
Michael
432eec770b Issue 5467: Cron jobs hadn't been executed 2018-07-24 06:15:58 +00:00
Michael
de984cdaa1 Issue 5467: Fix worker and daemon 2018-07-24 03:42:44 +00:00
Hypolite Petovan
30fff2077c Ad missing use statements after dbesc conversion 2018-07-23 18:44:05 -04:00
Hypolite Petovan
a6fb3568f9 Rename dbesc to DBA::escape 2018-07-23 15:30:54 -04:00
Hypolite Petovan
d3a598f589 Update DBA::escape to match dbesc() 2018-07-23 15:13:42 -04:00
Hypolite Petovan
538b81d10d Delete Database\DBM class file 2018-07-23 11:04:15 -04:00
Hypolite Petovan
aa26943f92 Rename DBA::esc_array to DBA::escapeArray 
- Rename internal method DBA::esc_array_callback to
DBA::escapeArrayCallback
 2018-07-23 11:04:15 -04:00
Hypolite Petovan
ecea7425f8 Rename DBA::is_result to DBA::isResult 2018-07-23 11:04:14 -04:00
Hypolite Petovan
0ec44f3e8a Rename DBM method calls to DBA method calls 2018-07-23 11:02:24 -04:00
Hypolite Petovan
8ddb94ef06 Use DateTimeFormat::utc() instead of DBM::date() 2018-07-23 10:57:47 -04:00
Hypolite Petovan
c55e389bbc Add Database\DBM methods to Database\DBA 2018-07-23 10:57:47 -04:00
Hypolite Petovan
38f341e064
Add missing space between PHP path and script in App->proc_run (#5468) 2018-07-23 10:43:39 -04:00
Michael Vogel
2d0a749734
Merge pull request #5431 from MrPetovan/task/5410-rename-database-methods 
Move DBA to src/ part 3.1: Rename DBA methods
 2018-07-23 15:18:58 +02:00
Hypolite Petovan
b685ef37c9
Fix Fatal errors in Protocol\OStatus (#5466) 2018-07-23 07:48:44 -04:00
Michael Vogel
53876abfda And some more removed notices in the core (#5465) 2018-07-23 07:43:18 -04:00
Philipp
cd52d0b3e9 Using getopt for CLI arguments (#5446) 
* Adding Argument class to Friendica

* Adding Argument class to Friendica

* Adding Argument class to Friendica

* fixing arguments for `spawnWorker`

* Adding `use Friendica\BaseObject` to `ApiTest.php`

* Refactoring the argument-usages of Friendica

* Refactoring the argument-usages of Friendica

* removing superfluous []
 2018-07-23 07:40:52 -04:00
Roland Häder
4eb6707dc9 Cleanup: (#5463) 
- rewrote x() to empty() as it is deprecated
- fixed indending for some entries
 2018-07-22 21:18:21 -04:00
Hypolite Petovan
cdd8e4fd9d Rename DBA::get_db to DBA::getConnection 
- Rename DBA::$db to DBA::$connection
 2018-07-22 19:28:29 -04:00
Hypolite Petovan
415b982d39 Rename DBA::num_rows to DBA::numRows 2018-07-22 19:27:35 -04:00
Hypolite Petovan
1f2c0b98b5 Rename DBA::server_info to DBA::serverInfo 2018-07-22 19:27:35 -04:00
Hypolite Petovan
4db98eb43d Rename DBA::inArray to DBA::toArray 2018-07-22 19:27:35 -04:00
Hypolite Petovan
f051ae1698 Rename DBA::fetch_first to DBA::fetchFirst 2018-07-22 19:27:34 -04:00
Hypolite Petovan
591939dfc0 Rename DBA::database_name to DBA::databaseName 2018-07-22 19:27:34 -04:00
Hypolite Petovan
abbaaf5aa5 Rename DBA::clean_query to DBA::cleanQuery 2018-07-22 19:27:34 -04:00
Hypolite Petovan
910e832dc2 Rename DBA::any_value_fallback to DBA::anyValueFallback 2018-07-22 19:27:34 -04:00
Hypolite Petovan
e42cf4d4fc Rename DBA::affected_rows to DBA::affectedRows 2018-07-22 19:27:34 -04:00
Roland Häder
d3144e2837 Need to load "verb" from notify table, too. This whole thing is a maintenance (#5459) 
nightmare. Let's use the new database frontend/backend system and load all
columns anywhere the "entity" is requested.
 2018-07-22 19:25:07 -04:00
Hypolite Petovan
bb99ac8111
Fix Fatal error in Protocol\Diaspora (#5460) 2018-07-22 19:22:41 -04:00
Roland Häder
7876d6547b Fixed E_NOTICEs when uploading profile picture (#5456) 
* Fixed E_NOTICEs when uploading profile picture.

* Fixed E_NOTICEs when $_POST doesn't contain these fields.
 2018-07-22 16:01:14 -04:00
Roland Häder
c17adaf333 Uncommon logger levels in Friendica (#5453) 
* "normal" is an uncommon logger level:
- changed LOGGER_NORMAL -> LOGGER_INFO
- added LOGGER_WARNING (a common logger level)

* Used constants instead of values (MrPetovan)
 2018-07-22 14:07:44 -04:00
Hypolite Petovan
a202962f03
Fix yet another Fatal Error in Protocol\OStatus (#5454) 2018-07-22 13:32:34 -04:00
Hypolite Petovan
d6ccba79e0
Fix another Fatal error in Protocol\OStatus (#5451) 
* Fix Fatal error in Protocol\OStatus

* Fix another Fatal error in Protocol\OStatus
 2018-07-22 12:57:33 -04:00
Roland Häder
7d47152564 Fixed E_NOTICE in boot.php and DBA class (#5430) 
* Fixes:
- fixed missing variable $port (MySQL: 3306)
- "imported" mysqli class

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixed:
- better use `false` and `$port > 0`

* And better only provide `$port` when larger zero.

* Initialize `$port` with zero value (int) and not `false` (bool).

* Removed duplicate mysqli "import".

* `$post_update` is no longer used. Instead `$prefix` needs to be checked.
 2018-07-22 12:53:46 -04:00
Hypolite Petovan
3500e50be9
Fix Fatal error in Protocol\OStatus (#5450) 2018-07-22 12:52:38 -04:00
Roland Häder
0a519f5001 Fixes/tye-hints (#5449) 
- added type-hints for DOMDocument, DOMXPath and array
- added missing documentation about optional parameter
- `if ($foo['bar'])` is not a good choice, better use
  `if (!empty($foo['bar']))` instead
 2018-07-22 12:35:20 -04:00
Roland Häder
2e332134d4 There is no LOGGER_WARNING (triggering E_NOTICE about absent constant). Either (#5448) 
declare it and push all other numbers higher or use LOGGER_NORMAL.
 2018-07-22 12:33:28 -04:00
Philipp
c5cbf565d9 DBStructure enhancements (#5437) 
* Adding DBStructure enhancements

- Added DBStructure::rename()
- Added DBStructure::existTable()
- Added DBStructure::existColumn()

(cherry picked from commit 4ae06ec)

* Adding `pre_update_1279` method

- Added DBStructure::rename()
- Added DBStructure::existTable()
- Added DBStructure::existColumn()

(cherry picked from commit 8496d84)

* code standards

(cherry picked from commit 551d09b)

* simplify to `empty` instead `is_null`

(cherry picked from commit ce68835)
 2018-07-21 08:43:43 -04:00
Michael
f02bcdba51 Automatically create a .htaccess when not existing 2018-07-21 05:41:19 +00:00
Tobias Diekershoff
e4a652cae8
Merge pull request #5433 from annando/mysqli 
Forgotten "use"
 2018-07-21 07:18:10 +02:00
Michael
4ba91d4ea1 Forgotten "use" 2018-07-21 05:09:09 +00:00
Michael Vogel
6a6a805225 One more notice (#5429) 
* Some more notices

* And some more notice in the worker
 2018-07-20 20:43:21 -04:00
Michael Vogel
4bbcb61a9e We now have a pre update script (#5425) 
* We now have a pre update script

* Some optimized stuff
 2018-07-20 15:47:16 -04:00
Michael Vogel
7382be2766 Some more notices (#5424) 2018-07-20 14:07:54 -04:00
Hypolite Petovan
af6dbc654f Rename Friendica\Database\dba to Friendica\Database\DBA 2018-07-20 08:19:26 -04:00
Tobias Diekershoff
b6a1df0598
Merge pull request #5420 from annando/notices 
Just some more fixed notice
 2018-07-20 12:46:42 +02:00
Michael
045358cb88 Wrong "use" for config 2018-07-20 06:04:23 +00:00
Michael
5c63de1692 Just some more fixed notice 2018-07-20 05:31:26 +00:00
Michael
9a6a3bf1c1 Makes Diaspora working again 2018-07-20 05:10:16 +00:00
Hypolite Petovan
9c70a94589 Add missing PDO* use statements in Database\dba 2018-07-19 22:24:03 -04:00
Hypolite Petovan
daa1177e3a Update use statement lists with new Friendica\Database\dba class 
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
 2018-07-19 22:15:21 -04:00
Hypolite Petovan
c316c5ae30 Add new Friendica\Database\dba class 2018-07-19 22:06:13 -04:00
Roland Häder
36c6e35c7e Misc cleanups (#5417) 
* Fixed http://github to https://github

Signed-off-by: Roland Häder <roland@mxchange.org>

* reverted back

Signed-off-by: Roland Häder <roland@mxchange.org>

* Added type-hint 'array' as the method uses foreach() on it.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Tpzo fixed ...

Signed-off-by: Roland Häder <roland@mxchange.org>

* Added missing new-line at end of file, will make some POSIX parsers being lesser
confused ...

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-19 20:52:18 -04:00
Michael Vogel
01b67c4eb3 Little fixes (#5414) 
* We now store the item delivery data in a separate table

* Reorganized table structure

* Fix  a notice when using the profiler / ensure that permissions are strings
 2018-07-19 18:40:39 -04:00
Roland Häder
b2899d76cf Small cleanup (#5416) 
- added internal TODO to decide about is_result() usage
- removed semicolon (not needed here) from SQL query
- added empty line

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-19 18:39:05 -04:00
Michael Vogel
ec49d004e3 We now store the item delivery data in a separate table (#5413) 
* We now store the item delivery data in a separate table

* Reorganized table structure
 2018-07-19 17:56:52 -04:00
Michael Vogel
5af9596dde New item field "Post-type" and new table "permissionset" (#5408) 
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* Changed documentation
 2018-07-19 09:52:05 -04:00
Roland Häder
b05b96d04a Fixes: (#5404) 
- fixed E_NOTICE in mod/follow.php
- fixed 2 E_NOTICE in src/Protocol/Diaspora.php
- added more type-hints for `array` type where known

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-19 07:07:14 -04:00
Roland Häder
346790cbbc According to @annando and @MrPetovan, $emailcc is no item field (column) and (#5401) 
should be initialized empty (I did it above the `if()` block).

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-18 17:26:14 -04:00
Pierre Rudloff
6e1ed0b0d3 Fix tests (#5400) 
* Avoid argc side-effects

* Fix undefined array keys in JITConfigAdapter::set()

* Avoid argv side effects in ApiTest
 2018-07-18 16:30:55 -04:00
Michael Vogel
2fa6cc0000
Merge pull request #5394 from MrPetovan/bug/fix-config-set-return-value 
Change (P)Config::set return value to bool
 2018-07-18 11:07:10 +02:00
Michael Vogel
66a103e36a
Merge pull request #5295 from MrPetovan/task/4889-move-config-to-config 
Move configuration to config/
 2018-07-18 11:04:35 +02:00
Hypolite Petovan
0f7c7cebeb Change (P)Config::set return value to bool 2018-07-18 02:32:35 -04:00
Hypolite Petovan
1b6727fb9c Fix notice in Util\Network 2018-07-17 21:00:22 -04:00
Roland Häder
a41e49c84a Fixes for E_NOTICE in mod/item.php (#5393) 
* Fixes applied:
- `if (is_array($some_array))` is better code style than `if ($some_array)` as
  the `if()` block really needs an array to be found
- same with `if ($some_id)`, maybe `if ($some_id > 0)` is a more proper check
- added missing field 'emailcc' to Item::ITEM_FIELDLIST

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixes E_NOTICE of missing variable (PHP's lazyness again).

Signed-off-by: Roland Häder <roland@mxchange.org>

* Use !empty() to avoid accessing empty array.

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-17 18:18:42 -04:00
Roland Häder
fd8897851f Fixes for OEmbed class (#5392) 
* Fixes:
- stdClass is clearly an object of `\stdClass`, so let's import it and set it
  as type-hint here
- if $o->type is not found, don't continue

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fix for a fix due to 02:51 a.m. (!) edits ...

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-17 16:28:20 -04:00
Hypolite Petovan
050ad68b9f Improve Console/Config display for array values 
- Prevent setting a config key that is an array
 2018-07-17 02:15:05 -04:00
Hypolite Petovan
d993c8584c Add support for legacy $lang config in App->loadConfig 2018-07-17 02:05:52 -04:00
Hypolite Petovan
007ec92ae4 Remove exception for legacy config file in App->loadDatabase 2018-07-17 02:05:36 -04:00
Hypolite Petovan
7b8efcc23d Fix config value type in MemcachedCacheDriver 
- Remove default config values set in CacheDriverFactory
 2018-07-17 02:05:06 -04:00
Roland Häder
04b513ba95 Fixed E_NOTICE when 'title' is absent (uninitialized array key) (#5390) 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-17 01:13:22 -04:00
Hypolite Petovan
bad2774817 Separate default config values between file-only and admin settings 2018-07-16 19:38:19 -04:00
Hypolite Petovan
67dc08d120 Enforce systen.register_policy value type 2018-07-16 19:38:19 -04:00
Hypolite Petovan
9b01a23c9b Code standards in App 2018-07-16 19:38:19 -04:00
Hypolite Petovan
763c66dd49 Improve console/config display 
- Add visual distinction between get/set value
 2018-07-16 19:38:18 -04:00
Hypolite Petovan
3001951075 Move the addon-specific config in config/addon.ini.php 
- Add sample addon.ini.php file
- Add config/addon.ini.php file to git ignore
 2018-07-16 19:38:18 -04:00
Hypolite Petovan
c8d3067d0a Fix JITConfigAdapter to retrieve non-db config.* values 2018-07-16 19:38:17 -04:00
Hypolite Petovan
bd04c03c9f Fix urlpath determination on the root page 2018-07-16 19:38:17 -04:00
Hypolite Petovan
0cbe3aa8e6 Remove global $db variable 2018-07-16 19:38:17 -04:00
Hypolite Petovan
820afa2284 Replace global $a with BaseObject::getApp() 2018-07-16 19:38:17 -04:00
Hypolite Petovan
d0780ccf7d Replace global $lang with system.language 2018-07-16 19:38:17 -04:00
Hypolite Petovan
6b03ae92b8 Fix Memached config value format usage 2018-07-16 19:38:16 -04:00
Hypolite Petovan
762a786611 Replace direct accesses to App->config by Config::get/set calls 2018-07-16 19:38:16 -04:00
Hypolite Petovan
3255b2364b Fix dbesc as a constant notice message 2018-07-16 19:38:15 -04:00
Hypolite Petovan
e98216b5bb Improve comparison in App->loadDatabase() 2018-07-16 19:38:15 -04:00
Hypolite Petovan
d8096a402c Update use of environment variables in loadDatabase 2018-07-16 19:38:15 -04:00
Hypolite Petovan
cd9b864045 Rework App modes 
- Replace App mode constants with capability-based flags
- Add App->isInstallMode()
- Add file config fallback in (P)Config abstraction
- Removed logger disabling code
 2018-07-16 19:38:15 -04:00
Hypolite Petovan
d487c399dd Standards: Rename App methods 
- Rename App->max_processes_reached to App->isMaxProcessesReached
- Rename App->maxload_reached to App->isMaxLoadReached
 2018-07-16 19:38:14 -04:00
Hypolite Petovan
73b4e0552d Fix wrong urlpath determination 2018-07-16 19:38:14 -04:00
Hypolite Petovan
3fc21f0d64 Fix config mentions (no doc) 2018-07-16 19:38:14 -04:00
Hypolite Petovan
2e2930d770 Add addon config hook 2018-07-16 19:38:14 -04:00
Hypolite Petovan
0448ca3897 Update install procedure 
- Fix Notice messages in Core\Install and Database\DBStructure
- Move local config file template from htconfig.tpl to local.ini.tpl
- Remove htconfig.php
 2018-07-16 19:38:14 -04:00
Hypolite Petovan
e7c3d453c2 Update config console command 2018-07-16 19:38:14 -04:00
Hypolite Petovan
fd7179ee6c Prevent infinite loops with Config when App is in install mode 2018-07-16 19:38:13 -04:00
Hypolite Petovan
3985a4bc43 Remove extraneous dba::connect calls 2018-07-16 19:38:13 -04:00
Hypolite Petovan
decfc553f7 Set BaseObject::setApp in App 2018-07-16 19:38:13 -04:00
Hypolite Petovan
e952d6677b Rename App->path to App->urlpath 2018-07-16 19:38:13 -04:00
Hypolite Petovan
5fdff3d813 Centralize startup steps in Friendica\App 
- Add loadDatabase startup step
- Add loadConfigFiles startup step
- Remove startup() in boot.php
- Replace App::checkMaintenanceMode() with App::determineMode()
 2018-07-16 19:38:13 -04:00
Hypolite Petovan
2503660f97 Add new INI config files 
- Add new local.ini.tpl template
- Change all references from .htconfig.php to config/local.ini.php
 2018-07-16 19:38:13 -04:00
Michael
95fe08e5b9 Ensure that "follow" requests can be processed 2018-07-16 06:34:12 +00:00
Michael
78c9e29aa8 Don't accept posts from unknown owners 2018-07-16 05:48:51 +00:00
Michael Vogel
d3a2ed85fe Next item structure works (#5380) 
* Use "LEFT JOIN" to always fetch the item. Needed for update routines.

* New conversion routine that now covers every item

* Post update is now activated

* We now use a hash based upon RIPEMD-320 for content and activity

* The hash doesn't contain the plink anymore

* Legacy item fields are now "null"able

* New hash function for a server unique item hash

* Introduction of the legacy mode (usage of old item fields)

* Code simplification

* We don't need the "uri" fields anymore in item-activity and item-content

* Use the "created" and not the "received" date for the hash

* Avoiding several notices

* Some more warnings removed

* Improved uri-hash / Likes on Diaspora are now getting a creation date

* Corrected the post update version

* Ensure an unique uri-hash

* Don't delete orhaned item data at the moment

* Partly reworked, due to strange behaviour

* Some more parts reworked

* Using the uri currently seems to be more reliable

* Using the uri here as well

* Use the hash values again

* Grouped item fields in different categories

* Notices again

* use the gravity (we always should)

* Added hint for disabled post updates

* Notices ...

* Issue #5337: Personal notes are displayed again

* Use the gravity again
 2018-07-15 14:36:20 -04:00
Hypolite Petovan
ffc8b2a79a Rework smilies class and module 
- Add new replaceFromArray function to enable smilies replacement with
an arbitrary array
- Moved $sample logic from class to module
 2018-07-15 08:03:12 -04:00
Hypolite Petovan
065d10e587 Fix function comments in Util\Network 2018-07-15 08:03:12 -04:00
miqrogroove
b5fe1c60a9 Fix Broken Profile Links (#5286) 
* Expose the block_public setting to head.tpl

* Do not include hovercard.js if block_public
 2018-07-14 16:31:46 -04:00
Roland Häder
6b5d90333f Fixes for some E_NOTICE and type-hints added (#5358) 
* Fixed http://github to https://github

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixes for #4965:
- updated messages.po file

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixed E_NOTICE where isset()/empty() was absent.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixed missing variable $sql_order causing E_NOTICE.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Continued:
- added array type-hint where known (some)

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixes:
- in Profile::load() $user is now only one-dimensional
- $a->get_hostname is no property, it is a method

Signed-off-by: Roland Häder <roland@mxchange.org>

* reverted changes that are unintended

Signed-off-by: Roland Häder <roland@mxchange.org>

* Continued:
- removed leading \ (uncommon, okay)
- removed entire if() block (CR by Hypolite)

Signed-off-by: Roland Häder <roland@mxchange.org>

* Removed if() block

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-13 15:47:14 -04:00
Tobias Diekershoff
26723623f4
Merge pull request #5363 from annando/daemin 
Workaround for stalling worker processes when running the daemon
 2018-07-11 08:26:09 +02:00
Michael
3cb7a7606e workaround for stalling worker processes when running the daemon 2018-07-11 06:05:22 +00:00
Roland Häder
8825728fa4 "Imported" name spaces (#5361) 
* Fixes for #5355:
- let's import SPL/extension classes and then just use them without name spaces
  like we do it with our own classes/interfaces, too.
- need to add namespace \ (global)

Signed-off-by: Roland Häder <roland@mxchange.org>

* Removed leading slashes from "import" lines.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Completed:
- "import" other classes, then use them

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-10 18:55:01 -04:00
Michael Vogel
3792e2819d Use a process identifier for logging that contains the pid (#5359) 2018-07-10 18:32:47 -04:00
Michael Vogel
0360f7197a Several more warnings ... (#5340) 
* Some more warnings removed

* Even more warnings ...

* Will it ever end? ;-)

* Avoid warning in dbstructure

* Origin and OStatus ...

* There are more warnings solved ... yeah!

* And again ...

* We are not done yet

* And more ...

* And some new places ...

* And more in the feeds

* Avoid some more

* And some backend stuff

* Notifications cleared

* Some more stuff

* and again ...

* It's getting fewer ...

* Some warnings had been hidden in the notifications

* Fix the fix

* And another missing one ...

* We need the owner here, not the user

* Forgotten user

* And more ...

* And some more warnings disappeared ...

* Some more frontend warnings

* Some backend warnings removed

* Fixed sidebar for "vier"

* And more ...

* Some more ...

* And something for "remote self"

* Am I stuck in an endless loop?

* Fix: Clear tag and file field on update

* Preset page content
 2018-07-10 08:27:56 -04:00
Andreas Neustifter
32ef5623ab [frio] Improve Group Editing (#5349) 
* Improve group-editing and edit-navigation.

Use icons next to groups and header for navigation to editing groups and adding new groups.
Also use icon from group-sidebar for editing groups.

* Unify look&feel of contact search bars.

* Remove nogroup page and replace with /group/none.

* Make sure proper items are selected in aside.

* Use icon instead of link for 'View Contacs' on profile page.

* Fix none-working /group/none.

* Fix highlighting for everyone in group aside.
 2018-07-09 18:36:50 -04:00
Andreas Neustifter
09b7e217c7 [Suggestion] Move New User Tip Link (#5342) 
* Move new member tips to navigation bar.

The link looks so forlorn when its just somewhere in there. Put it in the nav bar.

* Style new member hints link propery.

* Make changes requested by @MrPetovan.
 2018-07-09 18:20:57 -04:00
Philipp Holzer
a84c94e94b
bugfix isempty... 2018-07-09 22:10:35 +02:00
Philipp Holzer
d1eeaeead9
empty is not isset ... 2018-07-09 21:53:49 +02:00
Philipp Holzer
c829e43725
moved get_guid to System::createGUID 2018-07-09 21:38:16 +02:00
Hypolite Petovan
7211fc4f1a
Merge pull request #5338 from annando/warnings 
Remove warnings
 2018-07-08 09:55:26 -04:00
Michael
6d90751110 Added missing "use 2018-07-08 13:39:48 +00:00
Michael
1d745c25a7 Some more places ... 2018-07-08 12:58:43 +00:00
Michael
7d6933c898 Avoid "Trying to get property of non-object" 2018-07-08 11:46:05 +00:00
Philipp Holzer
269221f013
Merge branch 'develop' of https://github.com/friendica/friendica into redis_serialize 2018-07-08 13:36:05 +02:00
Philipp Holzer
be83696f02
Redis serialize instead of json because of objects 2018-07-08 13:35:28 +02:00
Michael
3e797547a3 Warnings fixed 2018-07-08 09:37:05 +00:00
Michael
c25c3b5981 urgent bugfix: Wrong function name for locks 2018-07-08 08:32:50 +00:00
Michael
c2d4b557ae Only build tag and file when really needed 2018-07-08 05:44:35 +00:00
Michael
69db696ab1 Improve test behaviour 2018-07-08 05:29:06 +00:00
Michael
271b6cb8f9 Hopefully this fixes the tests 2018-07-08 05:10:45 +00:00
Michael
74d5eec571 Merge branch 'item-activities' of github.com:annando/friendica into item-activities 2018-07-08 04:56:35 +00:00
Michael
5ee2db8a16 Avoid undefined index 2018-07-08 04:55:45 +00:00
Michael Vogel
ff5ee74ecf
Merge branch 'develop' into item-activities 2018-07-08 06:35:50 +02:00
Michael
75aa831b32 Better not check too strict 2018-07-07 23:31:30 +00:00
Michael
4673560c55 Don't use isset 2018-07-07 23:19:28 +00:00
Michael
4467dd4972 Clear legacy item fields 2018-07-07 23:03:28 +00:00
Michael
afa194200b Fix: Ensure that the value is set. 2018-07-07 19:39:00 +00:00
Michael
4d35e228c4 More item abstraction / making remote deletion work again 2018-07-07 18:14:16 +00:00
Philipp Holzer
065b83d148
Fixed memcache & unittests 2018-07-07 20:07:07 +02:00
Philipp Holzer
80a4e6263f
Added Unittests for cache 
fixed Lock & Cache bugs
 2018-07-07 19:46:16 +02:00
Philipp Holzer
1dafaa69c5
bug in memcached clear function 2018-07-07 18:43:55 +02:00
Philipp Holzer
f95c420801
bug in redis delete function 2018-07-07 18:39:33 +02:00
Michael
d6af9515ba Avoid storing an icid value when iaid is stored/Fix item retraction 2018-07-07 16:38:01 +00:00
Philipp Holzer
1ffe0cfd81
Added Lock Unittests & Bugfixings 
Added Redis Lock Unittests
Added Memcached Lock Unittests

Fixed a bug in dba
Fixed a bug in RedisLock
 2018-07-07 16:15:03 +02:00
Michael
575662c2d7 Just some code cleanup 2018-07-07 11:39:37 +00:00
Michael
3389e9b213 Removing of likes should work now on comments as well 2018-07-07 10:43:43 +00:00
Michael
b421e7708f Removing of orphaned activity and content data 2018-07-07 07:43:13 +00:00
Michael
9e262e6157 Better handling of empty content 2018-07-06 22:08:41 +00:00
Michael Vogel
3eec97aa6e
Merge pull request #5314 from MrPetovan/task/4889-fix-tests 
Fix tests after enabling PHP Notices
 2018-07-06 22:14:01 +02:00
Tobias Diekershoff
a49e094308 added forgotten trim 2018-07-06 15:49:27 +02:00
Tobias Diekershoff
72638acac3 admins can forbid some nicknames from being registered 2018-07-06 15:32:56 +02:00
Michael
0c51159111 New index that is needed for the expiry 2018-07-06 06:46:44 +00:00
Michael
7f78540454 Expire does work now for activities as well 2018-07-06 06:45:30 +00:00
Michael
5a07042560 Added warning 2018-07-06 06:37:33 +00:00
Michael
32d398cc93 Unified content that is stored for a like 2018-07-06 05:39:25 +00:00
Michael
da954b92c7 New post update to fill the item-activity table 2018-07-06 05:17:44 +00:00
Michael
f33bd5fc8e Update does work now 2018-07-06 05:16:40 +00:00
Michael
5203f41d42 Set iaid after update 2018-07-05 22:50:33 +00:00
Michael
014eea8e12 Improve expire for item-content and item-activity 2018-07-05 22:07:50 +00:00
Michael
44e405d22b We now store activities in a separate table 2018-07-05 22:00:38 +00:00
Philipp Holzer
5a28ad7377
AbstractCacheDriver now working for each CacheDriver 2018-07-05 22:01:33 +02:00
Philipp Holzer
749b167fd9
AbstractCacheDriver now working for each CacheDriver 2018-07-05 21:54:20 +02:00
Philipp Holzer
34cea93a8b
Bugfixings for Cache-Lock 
- used wrong cachekey in set
- therefore added an abstraction to avoid wrong key concatenation
- forgot to increase the db-version to 1275
 2018-07-05 21:47:52 +02:00
Philipp Holzer
e41e7d2edd
Fixings 
- fixed test for semaphore
- fixed some issues
- changed namespace in Tests back to "src/"
- changed namings
 2018-07-05 20:57:31 +02:00
Philipp Holzer
906bb25972
code standards / simplifications 2018-07-05 07:59:56 +02:00
Philipp Holzer
19209f6826
merged from develop and increased DB-version 2018-07-04 23:44:11 +02:00
Philipp Holzer
aac94d1d74
Adding multihost - locking 
Adding Unit-Tests for it
 2018-07-04 23:37:22 +02:00
Michael
176ab7130f Fixes issue 5322 - events now again are having a plink 2018-07-04 19:53:02 +00:00
Michael
f60da34357 Fix unliking liked 2018-07-04 19:07:53 +00:00
Philipp Holzer
b07dfbb03f
Merge remote-tracking branch 'remotes/origin/develop' into lock_abstraction 2018-07-03 20:16:31 +02:00
Michael
9a9541809b Fix: Likes from OStatus got the gravity of comments 2018-07-03 04:58:34 +00:00
Hypolite Petovan
79ff49d716 Replace more is_null with empty in DBStructure 2018-07-02 22:42:15 -04:00
Hypolite Petovan
e7d6b48bb3 Fix Undefined index: Collation in DBStructure 2018-07-02 22:28:27 -04:00
Hypolite Petovan
58e1470ddb Fix Undefined index: HTTP_USER_AGENT in App 2018-07-02 22:19:21 -04:00
Michael
80f9a45cba Fix: Twitter reshares hadn't been shown as this 2018-07-02 21:15:54 +00:00
Michael
4b3ae6a862 Only use query conditions in user mode 2018-07-02 18:22:27 +00:00
Hypolite Petovan
633a71ec97 Fix notice in Item::deleteById 2018-07-02 07:49:35 -04:00
Hypolite Petovan
07e06341df Simplify config.php_path access in App->proc_run 2018-07-02 07:48:33 -04:00
Hypolite Petovan
89e4629c16 Replace system.proc_windows config by PHP_OS test 2018-07-02 07:47:42 -04:00
Hypolite Petovan
a380bcd1c1 Fix more undefined variable/index notice in tests 2018-07-02 07:45:25 -04:00
Hypolite Petovan
6776c4e3f9 Fix some undefined variable/index notices in tests 2018-07-02 07:44:55 -04:00
Hypolite Petovan
28741c8366 Remove startup() function 
- Enable notice errors
 2018-07-02 07:23:47 -04:00
Michael
717ca0b7eb Use already fetched data for magiclink 2018-07-02 05:41:55 +00:00
Michael
37bc19673d Empty owner and author data 2018-07-01 19:33:42 +00:00
Michael
38160a48b0 Post update script to move old content from the item table 2018-07-01 19:02:29 +00:00
Michael
32a639891f Improved logging for expired items 2018-07-01 09:08:58 +00:00
Michael
bffdf96d87 The "file" variable isn't stored anymore in the item table 2018-07-01 07:57:59 +00:00
Michael
1905242a16 Added support for internal Diaspora links to accounts 2018-06-30 22:37:44 +00:00
Hypolite Petovan
0c553150ea
Merge pull request #5305 from annando/item-tags 
Tags aren't stored in the item table anymore
 2018-06-30 17:50:55 -04:00
Michael
60dcdd0b27 Preparation for not storing the file field into the item table. 2018-06-30 21:15:24 +00:00
Tobias Diekershoff
bc3a569b2f Label for the Events happening in the next 7 days was wrong 2018-06-30 17:34:27 +02:00
Michael
5ba1427806 We don't store tags in the item table anymore 2018-06-30 15:21:32 +00:00
Michael
0ab9f2e265 Preparations to not store the tags in the item table anymore 2018-06-30 13:54:01 +00:00
Michael
a8a189eec4 The detected language now moved to "item-content" as well 2018-06-30 05:18:43 +00:00
Michael
59f8cb16e5 Add item content before the transaction 2018-06-29 11:10:36 +00:00
Michael
a82cf2ae29 Delete item content for older item records 2018-06-29 06:51:48 +00:00
Michael
4807797eaf New worker to fix empty icid 2018-06-29 06:24:18 +00:00
Michael
6b31e72905 Fix for: empty posts and comments that hadn't been transmitted to Diaspora 2018-06-29 06:20:04 +00:00
Philipp Holzer
ad5ee75159
Deleting parameter-types of methods (lack of support in PHP 5.6) 2018-06-28 23:06:14 +02:00
Philipp Holzer
4b7be15560
Deleting return-types of methods 2018-06-28 23:02:00 +02:00
Philipp Holzer
3f7e4f5bb6
redesign of locking & caching 
- New Factory "CacheDriverFactory" for Cache and Locks
- Adding Redis/Memcached Locking
- Moved Lock to Core
- other improvements
 2018-06-28 22:57:17 +02:00
Michael
b705a91ccd Standards and some more replace item calls 2018-06-28 03:31:10 +00:00
Michael
51a58ec2e2 Fix for fetching false fer... (sorry) verbs 2018-06-27 20:25:24 +00:00
Michael
b3abe148a6 Remove comment 2018-06-27 20:11:09 +00:00
Michael
3918a31fc2 Remove unneeded logging 2018-06-27 20:08:02 +00:00
Michael
028c9f4da5 We now store the verb in the item-content as well 2018-06-27 19:37:13 +00:00
Michael
76dab3b2d7 Use gravity instead of verb 2018-06-27 18:09:33 +00:00
Michael
8c2f91573a Fix mail import 2018-06-27 18:09:13 +00:00
Philipp Holzer
acf6a5cb9e
minor changes 2018-06-26 23:44:30 +02:00
Philipp Holzer
d409a92ca2
minor changes 2018-06-26 23:43:43 +02:00
Philipp Holzer
dd085ae592
minor changes 2018-06-26 23:42:26 +02:00
Philipp Holzer
130893673c
Bugfixing ILockDriver (forgot isLocked) 2018-06-26 23:33:02 +02:00
Philipp Holzer
a57e6cfa1b
Moved Lock.php back to Utils 2018-06-26 23:28:07 +02:00
Philipp Holzer
2260b9c873
Merge branch 'develop' of https://github.com/friendica/friendica into develop 2018-06-26 22:56:08 +02:00
Philipp Holzer
0218d16335
Lock abstraction (like the Cache) 
- adding interface
- adding seperate drivers
- moving Lock to the Core package
 2018-06-26 22:31:04 +02:00
Hypolite Petovan
e3584daef9
Merge pull request #5167 from VVelox/develop 
a domain name is unlikely to be both a CNAME and A record
 2018-06-26 08:05:34 -04:00
Zane C. Bowers-Hadley
8875cc7419 remove duplicate check 2018-06-26 05:03:45 -05:00
Michael
f74a54b9bf Standard stuff 2018-06-26 03:58:12 +00:00
Michael
7aa880543f Fix shadow posts 2018-06-25 20:38:32 +00:00
Michael
6b568bb8fa Delete of item-content should work now 2018-06-25 20:23:32 +00:00
Michael
89f0eec261 Use a constant fieldlist 2018-06-25 18:49:36 +00:00
Michael
c07b81c5b9 Added workarounds to fetch the complete item content 2018-06-25 16:11:27 +00:00
Michael
5f3f349006 "author-link" and "owner-link" aren't stored anymore in the item table 2018-06-25 06:45:05 +00:00
Michael
6dbbeaf8f6 Remove unneeded code 2018-06-25 06:33:12 +00:00
Michael
89fb28ae9b Content is now stored exclusively in item-content, connected via "icid" field 2018-06-25 04:56:32 +00:00
Michael
941bab1096 We now only store the content in item-content 2018-06-24 23:09:13 +00:00
Michael
58d61810ea We now store item content centrally 2018-06-24 21:41:49 +00:00
Michael
d0c36d0e89 New table for storing item content 2018-06-24 14:33:07 +00:00
Michael
b03db4643f The fetch function now centrally controls the content 2018-06-24 10:48:29 +00:00
Michael
a7d2f126eb Fixes Issue 5276 and an endless loop in item::update 2018-06-23 10:32:53 +00:00
Tobias Diekershoff
585ba4c09f
Merge pull request #5279 from annando/issue-5278 
Issue 5278: Small corrections to the database definition
 2018-06-23 08:28:43 +02:00
Michael
ca1add20a0 Small corrections to the database definition 2018-06-23 04:46:22 +00:00
rabuzarus
92a84275d4 fix hovercard for not logged in users 2018-06-21 22:46:10 +02:00
Hypolite Petovan
8a3cae686b
Merge pull request #5261 from annando/and-again-abstraction 
And again the item abstraction - and a fix for issue 5252
 2018-06-21 11:50:31 -04:00
miqrogroove
80e96bcf38
Workaround for Bugs in Class dba 2018-06-21 11:20:44 -04:00
Michael
d643e00d33 Standards and a new function to fetch content 2018-06-21 15:14:01 +00:00
miqrogroove
7f4bce67a8
Update DBClean.php 2018-06-21 08:27:36 -04:00
miqrogroove
f2463e327a
Update DBClean.php 2018-06-21 07:52:56 -04:00
miqrogroove
cfe035f300
Update DBClean.php 2018-06-21 07:51:30 -04:00
miqrogroove
62e61a75f7
Make Conversation Cleanup Configurable 2018-06-21 07:43:40 -04:00
Michael
70af2cecf2 Some of the last direct SQL calls to the item table had been changed 2018-06-21 06:21:51 +00:00
Hypolite Petovan
e84c48b979
Merge pull request #5259 from rabuzarus/20180616_-_magic_auth_test_2 
port hubzillas OpenWebAuth - don't initiate magic auth if the contact is allready authentificated
 2018-06-20 20:15:14 -04:00
rabuzarus
02d96623f2 port hubzillas OpenWebAuth - don't initiate magic auth if the contact is allready authentificated 2018-06-21 02:08:54 +02:00
Hypolite Petovan
a5550b4702
Merge pull request #5253 from rabuzarus/20180616_-_magic_auth_test_2 
Port hubzillas OpenWebAuth - remote authentification
 2018-06-20 17:46:04 -04:00
rabuzarus
04fe3acb69 port hubzillas OpenWebAuth - fix method call 2018-06-20 23:29:36 +02:00
Roland Häder
8ad523fbc8
Continued a bit: 
- removed/fixed whitespaces and mixture of spaces/tabs (some)
- added new-line character at end of files (POSIX-compilant)
- reverted some code which I had messed up (compared to upstream/develop)
- removed duplicate dba::update() invocation in src/Protocol/DFRN.php
- also removed no longer valid TODO

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-06-20 22:19:54 +02:00
Michael
f806fa91b1
Replace old database queries with the new ones 2018-06-20 22:02:17 +02:00
Roland Haeder
593d1feca6
was a bit confusing for me or I was not sleeping to much ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:17 +02:00
Roland Haeder
2d744fa189
PHP5 does not support native type-hints, except array + used dbm::is_result() 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:17 +02:00
Roland Haeder
4ca26fd3bc
fixed comment and explained one 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:16 +02:00
Roland Haeder
a5dba628c4
old behaviour restored 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:16 +02:00
Roland Haeder
0e5daa86df
added curely branches + reverted back to old behaviour (may come back one day) 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:16 +02:00
Roland Haeder
ad9bd7bb72
better comment added by @Hypolite 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:16 +02:00
Roland Häder
fe77e1b538
added more curly braces + a bit more usage of dbm::is_result() 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-06-20 22:02:16 +02:00
Roland Haeder
f89b999659
was a bit confusing for me or I was not sleeping to much ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:15 +02:00
Roland Haeder
f0b05838cb
fixed comment and explained one 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:15 +02:00
Roland Haeder
a95db714ca
added curely branches + reverted back to old behaviour (may come back one day) 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:15 +02:00
Roland Haeder
63f5598766
better comment added by @Hypolite 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:15 +02:00
Roland Haeder
9cc0d5479b
old behaviour restored 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:15 +02:00
rabuzarus
9f493357f4 port hubzillas OpenWebAuth - fix wrong table name + fix wrong method name 2018-06-20 20:11:26 +02:00
rabuzarus
e4aaf8eb16 port hubzillas OpenWebAuth - fix some code standards violations 2018-06-20 19:32:26 +02:00
rabuzarus
149142b4bc port hubzillas OpenWebAuth - rename Verify class to OpenWebAuthToken 2018-06-20 19:24:02 +02:00
rabuzarus
d5afbd3357 port hubzillas OpenWebAuth - rename verify table to openwebauth-token 2018-06-20 19:18:41 +02:00
rabuzarus
1ab3f7bfc8 port hubzillas OpenWebAuth - HTTPSignature - comment out some ActivityPub parts 2018-06-20 19:05:33 +02:00
rabuzarus
863a49d8e7 port hubzillas OpenWebAuth - rework the HTTPHeaders class 2018-06-20 18:52:37 +02:00
rabuzarus
1148c29916 port hubzillas OpenWebAuth - use random_bytes() in crypto class + bugfixes 2018-06-20 18:45:37 +02:00
rabuzarus
f0235c4a98 port hubzillas OpenWebAuth - rename some methods and classes 2018-06-20 18:38:23 +02:00
miqrogroove
12d0f4bf3c
Add Comments to Worker Exponent Implementation 2018-06-20 06:43:57 -04:00
miqrogroove
9cde4aa109
Make Load Exponent Configurable 2018-06-20 06:22:53 -04:00
miqrogroove
97cabcecf2
Unify Worker Load Formulas 2018-06-20 06:06:20 -04:00
Michael
00124f9ac0 Makes the linear load calculation optional 2018-06-20 04:38:50 +00:00
miqrogroove
0dbddb240c
Update Worker.php 2018-06-19 18:55:55 -04:00
miqrogroove
7e4d7b9aac
Fix logic errors in tooMuchWorkers() 
There are probably a dozen different ways to do this, so this is not necessarily the "right" way.
 2018-06-19 18:53:02 -04:00
Hypolite Petovan
43ab1b2cf2
Merge pull request #5246 from annando/abstraction-encore 
Urgent bugfix: Non existing field / double "network" in field list
 2018-06-19 17:58:50 -04:00
Michael
c540154f8e "shadow" does not exist 2018-06-19 21:41:38 +00:00
Michael
962fbc9166 Many "fetch_first" had been replaced 2018-06-19 21:33:07 +00:00
Michael
139d35438d Fix: network had been empty 2018-06-19 21:32:42 +00:00
miqrogroove
79446a625d
Update Emailer.php 2018-06-19 16:58:06 -04:00
miqrogroove
5b8619f501
Add Missing Fifth Argument to mail() Function Call 
This is desperately needed to fix Issue #5190.  In case of any unexpected problem, the admin can use

`$a->config['system']['sendmail_params'] = false;`
 2018-06-19 16:23:42 -04:00
rabuzarus
b65e4b278b port hubzillas OpenWebAuth - use Contact::getIdForURL to query for contact entry 2018-06-19 16:15:28 +02:00
Michael
ed00b63613 Typo 2018-06-19 13:26:03 +00:00
rabuzarus
9195ea26b1 port hubzillas OpenWebAuth - add some notes to the doxygen to refer to hubzilla's source code 2018-06-19 13:30:55 +02:00
rabuzarus
af9116635b port hubzillas OpenWebAuth - readd some ActivityPup code to HTTPSig 2018-06-19 13:18:35 +02:00
Michael
ebd76285d8 New item functions, improved feed cache behaviour 2018-06-19 05:39:56 +00:00
rabuzarus
1c7f4e3c63 port hubzillas OpenWebAuth - remote authentification 2018-06-18 23:05:44 +02:00
Michael
4714cb746b Use the item functions at many more places 2018-06-18 20:36:34 +00:00
Michael
507956818d Use the item classes where possible 2018-06-18 05:19:28 +00:00
Michael
2a76290d19 Using the constants 2018-06-17 21:55:01 +00:00
Michael
23aa9dffa0 New item functions are now used in the delivery process as well 2018-06-17 21:35:33 +00:00
Michael
e42b934807 Item field list structure is unified 2018-06-17 17:14:52 +00:00
Michael
6e10de9284 New function to fetch item data especially for users 2018-06-17 17:05:17 +00:00
Michael
0280a46ab4 Use predefined field lists 2018-06-17 06:27:52 +00:00
Michael
1aec8f620d More item abstractions for DFRN and Diaspora 2018-06-16 22:32:57 +00:00
Hypolite Petovan
7d1bb9ecf4
Merge pull request #5230 from annando/new-item-uri 
New function for generating item URI
 2018-06-16 10:54:56 -04:00
Hypolite Petovan
133cd342d4
Merge pull request #5226 from annando/even-more-abstraction 
More item calls have been replaced with the new functions
 2018-06-16 07:57:00 -04:00
Tobias Diekershoff
7966c48e75
Merge pull request #5228 from annando/fix-5199 
Fix for PR 5199: Corrected check for empty object
 2018-06-16 09:42:36 +02:00
Michael
d2da5d63c7 Fix for PR 5199: Corrected check for empty object 2018-06-16 07:26:09 +00:00
Michael
14cb128264 New function for generating item URI 2018-06-16 06:44:19 +00:00
Hypolite Petovan
c651641856 Fix PHP 7.2 Warning in Model\Contact 2018-06-15 20:50:31 -04:00
Michael
bb79b8f4ac More item calls have been replaced with the new functions 2018-06-15 22:30:49 +00:00
Michael
e97a3c25e7 Multiple daemon improvements (foreground, faster spawning) 2018-06-15 18:18:20 +00:00
Tobias Diekershoff
71b017bfad
Merge pull request #5219 from annando/abstraction-2 
Reworked notifications / use of Item class to fetch data
 2018-06-15 09:54:50 +02:00
Michael
02fef0bcf5 Reworked notifications ("alt pager" added) / use of Item class to fetch data 2018-06-15 05:50:28 +00:00
Hypolite Petovan
6191fab4d7
Merge pull request #5216 from abanink/2337 
solves 2337 Smiley Pack 1.04: some smiley keywords aren't replaced correctly
 2018-06-14 15:36:21 -04:00
Pascal Deklerck
ce4b793acf solves 2337 Smiley Pack 1.04: some smiley keywords aren't replaced correctly 2018-06-14 21:09:55 +02:00
Hypolite Petovan
f0c2b77157
Merge pull request #5215 from rabuzarus/20180614_-_frio_contact_suggestion_template 
Frio: provide a template for received contact suggestions
 2018-06-14 13:56:30 -04:00
rabuzarus
b8186ba98b Frio: provide a template for received contact suggestions 2018-06-14 17:05:23 +02:00
fabrixxm
574bfecdfd Create config keys if they not exists on set. 2018-06-14 13:18:01 +02:00
Michael
77c423ec04 Don't allow deletion of public posts 2018-06-13 19:19:17 +00:00
Hypolite Petovan
0bcf7b7c39 Fix PHP 7.2 sizeof notice messages in Protocol\PortableContact 2018-06-12 22:01:50 -04:00
Hypolite Petovan
d71281e45b
Merge pull request #5193 from annando/dbstructure 
Fix: Avoid endlessly dbstructure changes
 2018-06-11 09:53:03 -04:00
Michael
b9811f1bef Fix: Avoid endlessly dbstructure changes 2018-06-11 13:22:08 +00:00
Michael
5bfd424fd2 Clean up tag claud (remove "item_condition()" call) 2018-06-10 15:19:52 +00:00
Michael
4d4cce4867 The new function is now used here as well. 2018-06-10 10:14:53 +00:00
Michael
446a45003d Added documentation, some indention fixes 2018-06-09 19:12:13 +00:00
Michael
baf316e898 The central item fetch does work now and the API now uses these functions 2018-06-09 16:56:37 +00:00
Michael
4874e589f1 New class function to fetch items 2018-06-07 06:03:12 +00:00
Michael
1304dae0d3 Bugfix: In the daemon mode we forgot to call the cron jobs 2018-06-06 03:48:04 +00:00
Hypolite Petovan
0a13ab6b9f
Merge pull request #5166 from annando/unsed-item-fields 
Remove unused, unneeded or redundant item fields
 2018-06-03 12:19:50 -04:00
Hypolite Petovan
973ece09c5
Merge pull request #5157 from annando/daemon 
Workers can now be started exclusively from the daemon and other workers
 2018-06-03 12:18:47 -04:00
Michael
b654af28fa We need "global" 2018-06-03 09:40:32 +00:00
VVelox
ea64ec21ac
a domain name is unlikely to be both a CNAME and A record 2018-06-03 04:29:06 -05:00
Michael
d7c477d0f4 Don't probe anymore, but ensure that we got good contact data 2018-06-03 08:36:05 +00:00
Michael
3f07d01dd1 Get rid of unneeded or redundant fields 2018-06-03 07:42:56 +00:00
Hypolite Petovan
0eafea86ed
Merge pull request #5163 from annando/bugfix-user-item 
Fix SQL error in tagcloud
 2018-06-02 13:49:58 -04:00
Michael
41423e578a Fix SQL error in tagcloud 2018-06-02 17:07:28 +00:00
Michael
c6c94b8cea Weird stuff 2018-06-02 13:00:47 +00:00
Michael
81c002370e Only redirections to the same host do make sense 2018-06-02 08:42:46 +00:00
Michael
723b5ae803 Use MagicLinkbyId when possible 2018-06-02 08:28:01 +00:00
Michael
8a34895a23 Use magicLink whenever possible 2018-06-02 08:05:06 +00:00
Michael
885f2b52d1 Merge remote-tracking branch 'upstream/develop' into public-redir 2018-06-02 06:18:45 +00:00
AndyHee
2b25bd48d4 Improved distinction between delete and remove 2018-06-02 12:40:41 +07:00
Michael
371f511954 Respect "don't fork" 2018-06-02 05:17:32 +00:00
Michael
3034170088 DBStruxture can now create "memory" tables as well 2018-06-02 05:03:23 +00:00
AndyHee
a75d28e521 Rewording label 2018-06-02 11:23:27 +07:00
Michael
6d64667cdb Merge remote-tracking branch 'upstream/develop' into daemon 2018-06-02 04:03:55 +00:00
Michael
047c02371a Small corrections to the database descriptions 2018-06-01 22:12:35 +00:00
Michael
28f8beebfc Workers can now be started exclusively from the daemon and other workers 2018-06-01 22:09:27 +00:00
Michael
b5b172500d Merge remote-tracking branch 'upstream/develop' into public-redir 2018-06-01 12:32:51 +00:00
Hypolite Petovan
93daf7883e Merge branch 'master' into develop 
- Updated new develop version label
- Incremented database build number
 2018-06-01 07:30:04 -04:00
Michael
ae8d7267a0 "redir" is now centralized and works with the public contact 2018-06-01 06:46:34 +00:00
Tobias Diekershoff
9ea6d4b26d the detected language was not stored during user creation 2018-05-31 08:27:27 +02:00
Michael
c86111d193 Coding standards 2018-05-29 19:00:26 +00:00
Pascal Deklerck
1853c5623b 4419 Update the comments in src/Database/DBStructure.php from doc/database/* 2018-05-29 10:24:36 +02:00
Michael
8329705eba New function to delete items for users 2018-05-29 05:22:57 +00:00
Michael
deb015be12 Changed documentation 2018-05-27 10:42:47 +00:00
Michael
c5a22f86c7 Merge remote-tracking branch 'upstream/2018.05-rc' into deleted-item 2018-05-27 10:38:49 +00:00
rabuzarus
32c3762989
Merge pull request #5138 from annando/optimize-workerqueue 
Possibly fixes 5137: Only execute "optimize table" when allowed
 2018-05-27 10:10:11 +02:00
Michael
04fd6eff01 Possibly fixes 5137: Only execute "optimize table" when allowed 2018-05-27 06:23:18 +00:00
Michael
708ddf2b02 Preparation for new deletion functionality 2018-05-26 20:23:49 +00:00
Michael
a6396dde55 Removed useless line 2018-05-26 20:08:42 +00:00
Michael
a50805c371 Grammar fix 2018-05-26 20:07:30 +00:00
Michael
bdbc51229a Fix for not being able to delete items 2018-05-26 18:07:27 +00:00
rabuzarus
c66d1f01a3 add missing database use statements 2018-05-25 09:05:16 +02:00
rabuzarus
f013625382 fix typo in comment 2018-05-25 08:52:03 +02:00
rabuzarus
8174bfeb2b Bugfix: compute the current theme each time we want to know which theme is beeing used 2018-05-25 08:44:01 +02:00
Michael
4a67919be7 Issue 5010: Don't show removed users 2018-05-24 04:44:02 +00:00
Michael
89a20ddbd7 Nodeinfo: The number of comments is now calculated more reliable 2018-05-22 20:10:18 +00:00
Michael
df531cd400 Don't proxy pictures when they are sent to other networks 2018-05-21 10:15:50 +00:00
Hypolite Petovan
c41332364f
Merge pull request #5089 from tobiasd/20180519-tos 
privacy statement
 2018-05-20 08:20:16 -04:00
Tobias Diekershoff
d78b1f5191
Merge pull request #5091 from annando/issue-4956 
Don't fail during installation because of a missing theme configuration
 2018-05-20 08:50:28 +02:00
Tobias Diekershoff
f7c24a20ae cite: just some small styling thing 2018-05-20 08:43:43 +02:00
Michael
9d0ed1a2af Issue 4956: Don't fail during installation because of a missing theme configuration 2018-05-20 05:44:20 +00:00
Michael
c70ebadd7d Issue-3412 related: Don't send connection posts anymore 2018-05-19 19:34:51 +00:00
Tobias Diekershoff
2798d4ea4d missing sign 2018-05-19 19:08:50 +02:00
Tobias Diekershoff
4f8530070b removed one line too much 2018-05-19 19:07:13 +02:00
Tobias Diekershoff
e02093c7ea text of the priv. statement can now be shown outside of the module 2018-05-19 18:55:29 +02:00
Michael
3fe07cca57 Issue 2880: Editing post doesn't destroy mentions or hashtags anymore 2018-05-19 14:55:27 +00:00
Tobias Diekershoff
5ae9193aa7
Merge pull request #5084 from annando/dead-subscriber 
End subscription for unreachable subscribers
 2018-05-19 07:07:00 +02:00
Michael
e9848d7b8f End subscription for unreachable subscribers 2018-05-19 03:56:29 +00:00
Michael
5d708fd9a9 Avaoid warning when no valid data could be read 2018-05-18 16:07:55 +00:00
Hypolite Petovan
83ff57777f
Merge pull request #5079 from annando/fix-self 
Fix: Sometimes the contact endpoints seem to be wrong
 2018-05-18 08:54:00 -04:00
Michael
8983c61023 Fix: Sometimes the contact endpoints seem to be wrong 2018-05-18 12:26:10 +00:00
Michael
feb3d76a5b Fix: Subscriptions from GNU Social partially don't work 2018-05-18 12:18:12 +00:00
Hypolite Petovan
1d2b0c0a81
Merge pull request #5077 from annando/fix-blocking-ostatus 
Fix to OStatus delivery to be not so blocking to other tasks
 2018-05-17 19:59:08 -04:00
Michael
4355014492 Now it should work ... 2018-05-17 23:47:15 +00:00
Michael
f4a71b76dd Dynamic priority handling 2018-05-17 23:43:44 +00:00
Michael
61824119e4 Moved functionality in new model class 2018-05-17 23:30:49 +00:00
Michael
5a1e1c1ec9 Fix to OStatus delivery to be not so blocking to other tasks 2018-05-17 22:17:03 +00:00
Tobias Diekershoff
41b7d75cca
Merge pull request #5072 from Alkarex/ru-plural-intval-bug 
i18n ru intval bug
 2018-05-17 09:43:25 +02:00
Alexandre Alapetite
f980516545 Fix PoToPhp 
https://github.com/friendica/friendica/pull/5072#issuecomment-389754406
 2018-05-17 08:12:55 +02:00
Tobias Diekershoff
ac67f3c154
Merge pull request #5071 from annando/fix-duplicated-posts 
Bugfix: Only send a notifier when the item was really edited
 2018-05-17 07:59:56 +02:00
Michael
b333c7ae2e Bugfix: Only send a notifier when the item was really edited 2018-05-17 05:49:55 +00:00
Roland Häder
6129eb1623
OpenId possibly fixed: 
- The LightOpenId class' constructor now requires the hostname from where the
  requested started, added it now
- sometimes need to invoke get_app() as $a was not around

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-17 00:24:25 +02:00
Michael Vogel
e8e93768db
Merge pull request #5065 from tobiasd/2018.05-rc 
added link to the TOS page if it is activated
 2018-05-16 14:21:24 +02:00
Tobias Diekershoff
eec0826750 added link to the TOS page if it is activated 2018-05-16 11:57:06 +02:00
Michael
3b2752c2fe Follow up to PR 5060: Missing index update 2018-05-16 08:59:15 +00:00
Michael
84248ac4c1 Grammar stuff 2018-05-16 03:54:08 +00:00
Michael
c9f55f6b3d Show "Remove from your screen" or "delete" depending of the impact of the deletion 2018-05-15 21:06:34 +00:00
Michael
e77cd17495 We do the notify stuff now directly in the item class 2018-05-15 19:50:29 +00:00
Michael
fe8a4d50c8 Merge branch 'item-delete' of github.com:annando/friendica into item-delete 2018-05-15 19:31:05 +00:00
Michael
4a1bbd114c Lower priority for "remote self" 2018-05-15 19:29:14 +00:00
Michael
82937189ba Only delete undeleted items 2018-05-15 19:25:35 +00:00
Michael
fc60e23314 Added comments / hourly workerqueue deletion 2018-05-15 17:50:29 +00:00
Michael
3e475f3b82 Delete the shadow post when it is the last one 2018-05-15 16:40:13 +00:00
Michael
4a7bf95926 Fix: Delete all item copies if it is an original item 2018-05-15 15:51:58 +00:00
Tobias Diekershoff
0848cef605
Merge pull request #5055 from annando/worker-spawning 
Fix for the slow spawning of workers
 2018-05-15 08:22:33 +02:00
Tobias Diekershoff
ba4f9b6136
Merge pull request #5054 from annando/diaspora-comments 
Fix: public comments weren't distributed to the followers.
 2018-05-15 07:30:34 +02:00
Michael
8564eeec4e Fix: public comments weren't distributed to the followers. 2018-05-15 04:33:28 +00:00
Roland Häder
e409001dfb
Fixed "constant" result, maybe there is a $ missing? 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-15 03:26:20 +02:00
Roland Häder
538760d9da
No direct $a->config['foo'] needed when Config::get() is around ... 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:50:05 +02:00
Roland Häder
751394fc1d
Redis: 
- added support for redis server:

// Required to actually have this cache driver active:
$a->config['system']['cache_driver'] = 'redis';

// ---- OPTIONAL/DEFAULT: ----
$a->config['system']['redis_host'] = '127.0.0.1';
$a->config['system']['redis_port'] = 6379;

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:50:05 +02:00
Roland Häder
69ac6feff7
Continued: 
- you can directly use constant($var) instead of this switch()

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:50:05 +02:00
Roland Häder
fe1e7b92f2
Continued: 
- system,worker_dont_fork may not be set, always set default to "false" to
  have it properly set as Config::get() may one day behave differently

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:50:05 +02:00
Roland Häder
57e668d9e0
Continued: 
- avoided else() block which reduces code complexibility
- used more x()
- added curly braces
- added known type-hints

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:50:05 +02:00
Michael
17a39340b5
"pending" shouldn't be set as well by default ... 2018-05-14 22:50:04 +02:00
Michael
f28301e18f
Urgent bugfix: Public contacts had been blocked automatically when created 2018-05-14 22:50:04 +02:00
Michael
72f5b863d8
Reshares had been detected falsely so that were rejected by Diaspora 2018-05-14 22:50:04 +02:00
Michael
f19066c6cf
Ensure that the link will be displayed correctly on Diaspora 2018-05-14 22:50:04 +02:00
Michael
dcfd81e2ee
Some corrections 2018-05-14 22:50:04 +02:00
Michael
d54c79a772
Replace old database queries with the new ones 2018-05-14 22:50:04 +02:00
Roland Haeder
11dcb31960
was a bit confusing for me or I was not sleeping to much ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:02 +02:00
Roland Haeder
ce07c20130
PHP5 does not support native type-hints, except array + used dbm::is_result() 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:02 +02:00
Roland Haeder
6579396627
removed TODO, one day this all needs refacturizing ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:02 +02:00
Roland Haeder
7526afcf13
Continued: 
- converted multiple single-line comments into one multi-line comment (please
  stop abusing programming languages!)
- added more TODO tags for type-hints (upcoming rewrite)
- opps, one space was only fixed in develop branch, not in this PR branch

Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:02 +02:00
Roland Haeder
f5f1650b62
fixed comment and explained one 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:02 +02:00
Roland Haeder
1fcd4f52e7
old behaviour restored 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:01 +02:00
Roland Haeder
87bb934f8f
added curely branches + reverted back to old behaviour (may come back one day) 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:01 +02:00
Roland Haeder
116d0ee1e0
better comment added by @Hypolite 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:01 +02:00
Roland Häder
e5c4b0203a
added more curly braces + a bit more usage of dbm::is_result() 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:50:00 +02:00
Michael
7e54499856
"pending" shouldn't be set as well by default ... 2018-05-14 22:50:00 +02:00