Commit graph

763 commits

Author SHA1 Message Date
Dundar Göc
c0131f2a17 Fixed shellcheck warning SC2034
SC2034: ___ appears unused. Verify use (or export if used externally).

I opted to remove the variables since they didn't seem to be used
anywhere.
2021-02-14 14:07:56 +01:00
Orazio
58af83b882
Merge pull request #1250 from DundarGoc/test
Fixed wrong path to script in the travis file.
2021-02-14 09:49:06 +01:00
Dundar Göc
aab8bc2563 Fixed wrong path to script in the travis file. 2021-02-13 23:52:27 +01:00
4s3ti
f559bfcb9f
Merge pull request #1249 from DundarGoc/test
Fixed shellcheck issue SC2015
2021-02-13 23:23:27 +01:00
Dundar Göc
8aa4607e5e Fixed shellcheck issue SC2015: Note that A && B || C is not if-then-else. C may run when A is true.
Replaced [ $1 -gt 1 ] && shift $1 || shift with shift $1 since
shift 1 is identical to shift.
2021-02-13 22:40:05 +01:00
4s3ti
48052e2f24
Merge pull request #1247 from DundarGoc/test
Fixed shellcheck SC2155: "Declare and assign separately to avoid masking return values."
2021-02-13 20:43:33 +01:00
Dundar Göc
3517f27d5b Fixed shellcheck warning SC2155: "Declare and assign separately to avoid masking return values." 2021-02-13 13:02:10 +01:00
Orazio
309c2cc7d5
Merge pull request #1246 from DundarGoc/test
Fixed shellcheck warning SC2164: "Use 'cd ... || exit' or 'cd ... || ……return' in case cd fails."
2021-02-13 12:48:30 +01:00
Dundar Göc
fe636e3f43 Fixed shellcheck warning SC2164: "Use 'cd ... || exit' or 'cd ... || return' in case cd fails." 2021-02-13 12:11:49 +01:00
Orazio
8d2a800851
Merge pull request #1245 from orazioedoardo/default-no
Default VPN protocols to unsupported (workaround for issue #1239)
2021-02-12 10:58:12 +01:00
Orazio
342d8dfa2c Default VPN protocols to unsupported (workaround for issue #1239) 2021-02-11 15:27:43 +01:00
Orazio
435c4f39c7
Merge pull request #1243 from MichaIng/patch-1
Skip WireGuard module build on Raspbian if it's built-in
2021-02-08 21:32:38 +01:00
MichaIng
7cc5da39cb Skip WireGuard module build on Raspbian if it's built-in
Meanwhile the Raspberry Pi kernel package with Linux 5.10 and built-in WireGuard module has been released. It hence became effective to make use of the built-in module check on Raspbian as well to skip the overhead of kernel headers install and DKMS module build.

Additionally, when adding Bullseye repositories to make available the WireGuard packages, say so explicitly. "Adding Debian repository" / "Adding Raspbian repository" is confusing when running a Debian / Raspbian system with those repositories added already, only with an distro release.

Signed-off-by: MichaIng <micha@dietpi.com>
2021-02-08 15:52:56 +01:00
Orazio
c2b912c2ff
Merge pull request #1242 from DundarGoc/test
Fixed shellcheck warning SC2004, SC2006, SC2129, SC2219. Issue #1233.
2021-02-08 08:34:26 +01:00
Dundar Göc
513c2afc2e Fixed shellcheck warning SC2004, SC2006, SC2129, SC2219. Issue #1233.
SC2004: "$/${} is unnecessary on arithmetic variables."
SC2006: "Use $(...) notation instead of legacy backticked `...`."
SC2129: "Consider using { cmd1; cmd2; } >> file instead of individual redirects."
SC2219: "Instead of 'let expr', prefer (( expr ))."
2021-02-07 21:31:13 +01:00
4s3ti
d67095f3ef CI/CD Fine tuning
Moved xenial script tests to After_script
Find script files instead of hardcoded scripts
2021-02-06 22:46:08 +01:00
4s3ti
bccaa1bbee Fix for #1234 & CI/CD Fine-tunning
Changed Exit code from 1 to 0
Added some more checks
Changed order some checks are done
2021-01-28 01:33:03 +01:00
4s3ti
0f7da9e690 Update Changes
updated latestchanges
2021-01-26 17:23:01 +01:00
Carlos Colaço
4b63a854cb Adding Missing CI Scripts
Added CI Scripts to use with Travis ci/cd
2021-01-26 16:39:30 +01:00
Carlos Colaço
26c0cf50cf First automated testing implementation
Added some builds on travis ci,
Runs linting on All scripts
installs OpenVPN and Wireguard on all supported ubuntu versions
Checks if VPN is running after installed
runs pivpn scripts
2021-01-26 16:34:06 +01:00
4s3ti
cae160ebf9
Merge pull request #1232 from glitch452/test
Fix exit codes when running a secondary script
2021-01-25 11:02:40 +01:00
glitch452
be692a8782 Pass along exit code when running a sub-script, instead of always running exit 0 2021-01-23 15:58:03 -05:00
glitch452
9131f2754a Change exit code to non-zero when running without Sudo 2021-01-23 15:57:26 -05:00
Carlos Colaço
5a81da9912 Better descriptions on Latest Update
changed LatestUpdate.md to be more descriptive before merging to master
2021-01-17 18:21:59 +01:00
Carlos Colaço
3eecc818d6 Update notes
Updated merge notes
2021-01-17 17:57:38 +01:00
Carlos Colaço
586c631b9e MR #1194
Added the fix mentioned on #1194 with the correction requsted on the
review
2021-01-17 17:35:01 +01:00
4s3ti
8d12aa654c
Merge pull request #1223 from 4s3ti/fix_update_pkg_cache
Fix for #1204

Added -y to $UPDATE_PKG_CACHE
updatePackageCache() no longer checks if apt update was run, it will
always update package cache since its a requirement
Replaced all updates using ${UPDATE_PKG_CACHE} with
updatePackageCache()
2021-01-17 17:10:33 +01:00
Carlos Colaço
7095357f92 Fix for #1204
Added -y to $UPDATE_PKG_CACHE
updatePackageCache() no longer checks if apt update was run, it will
always update package cache since its a requirement
Replaced all updates using ${UPDATE_PKG_CACHE} with
updatePackageCache()
2021-01-12 17:08:15 +01:00
4s3ti
9499b5282c
Merge pull request #1220 from mwoolweaver/test
use proper English in bug_report.md
2021-01-11 10:29:17 +01:00
Michael Woolweaver
c6ee331d18
still failed 2021-01-09 04:45:46 -06:00
Michael Woolweaver
5a7813d320
use proper english
since I couldn't 

5b404ccd9c
2021-01-09 04:42:31 -06:00
4s3ti
ae5a49ca59 Change issue template
Changed issue template from pivpn.dev to pivpn.io
2021-01-08 16:07:22 +01:00
4s3ti
d1f8c631fd
Merge pull request #1214 from mquirin/test
Fixes for #1212:

    Changes phrasing of the confirmation prompt when removing a wg config (from "[Y/n]" to "[y/N]")
    Prints to stdout that operation is aborted
    Returns exit code 1
2020-12-28 10:16:18 +01:00
mquirin
6448cc268a
Merge branch 'test' into test 2020-12-26 23:39:48 +00:00
Michael
f3eddccee8 wording and exit code 2020-12-26 23:34:54 +00:00
Orazio
db1fe2ebdd
Merge pull request #1186 from shelleycat485/test
A feature to disable / enable single wireguard client configs
2020-12-24 10:30:25 +01:00
Roger Haxby
ec32851e0c fix clientSTAT.sh error if all clients are disabled 2020-12-15 14:17:05 +00:00
Orazio
b369a02d5b
Merge pull request #1201 from MichaIng/patch-1
Fix WireGuard support detection
2020-12-14 15:17:32 +01:00
Orazio
a52e53d123 'sudo mktemp' creates file with 0600 mode, which means we need root to read it. 2020-12-14 15:15:29 +01:00
MichaIng
5077d70a2f Fix WireGuard support detection
Support was enabled automatically if a WireGuard package was found or could have been made available. But if the WireGuard kernel module is not available, it needs to be compiled. The required kernel headers are only reliably known for Raspberry Pi (Raspbian) and for amd64. This commit resolves the related issue where linux-image-amd64 was attempted to be installed on non-amd64 systems: https://github.com/pivpn/pivpn/issues/1180

Additionally this commit resolves the issue that kernel headers were required and a DKMS build done, even if the module was builtin, when no WireGuard package was found.

The $NEED_WIREGUARD_REPO variable has been replaced with $AVAILABLE_WIREGUARD, which practically serves the same information and allows a simpler support check.

Signed-off-by: MichaIng <micha@dietpi.com>
2020-12-14 14:54:46 +01:00
Roger Haxby
86de3eaa8c corect help on disable and enable 2020-12-10 23:59:54 +00:00
Roger Haxby
8bff0b6cb6 clientSTAT shows disabled clients at end 2020-12-10 12:34:49 +00:00
Roger Haxby
a3b7af869c more disabled in brackets 2020-12-09 23:07:28 +00:00
4s3ti
13e10cfe35 Merge branch 'test' of ssh://github.com/pivpn/pivpn into test 2020-12-09 19:23:38 +01:00
4s3ti
ff0ac0304c ProBot Stale
Added probot integration to marke topics as inactives and automatically
close them.
read .github/stale.yml for more details.
2020-12-09 19:22:29 +01:00
Roger Haxby
6009e52e74 disabled in square brackets 2020-12-08 23:44:51 +00:00
Orazio
418a857921 Merge branch 'test' of https://github.com/pivpn/pivpn into test 2020-12-05 12:38:25 +01:00
Orazio
dc744a9810 Fix directory and symbolic link creation when reconfiguring (writing over the same files) 2020-12-05 12:35:19 +01:00
Orazio
308affe4e9 Workaround for the following error on Ubuntu 20.04:
- /usr/bin/debconf-apt-progress: can't open /tmp/tmp.0CoNypDEPj: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.
    Reason: https://askubuntu.com/questions/1250974/user-root-cant-write-to-file-in-tmp-owned-by-someone-else-in-20-04-but-can-in
2020-12-05 12:35:11 +01:00
Orazio
5aac8bca84 Changed WireGuard unit path to /lib/systemd/system/wg-quick@.service
- On Raspbian, /lib is not a symbolic link to /usr/lib, so the WireGuard unit won't be found.
    Therefore changed to /lib/... (which is the default location for units of installed packages).
2020-12-05 12:35:02 +01:00