scripts/wireguard/removeCONF.sh
* SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
* Disabled warning
* SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
* Replaced LIST=($(...)) with mapfile
* SC2086: Double quote to prevent globbing and word splitting.
* Added double quotes
* SC2154: <VarName> is referenced but not assigned.
* Disabled warning
scripts/wireguard/pivpnDEBUG.sh
* SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
* Disabled warning
* SC2154: <VarName> is referenced but not assigned.
* Disabled warning
* SC2086: Double quote to prevent globbing and word splitting.
* Added double quotes
scripts/wireguard/makeCONF.sh
* SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
* Disabled warning
* SC2154: <VariableName> is referenced but not assigned.
* Disabled warning
* SC2086: Double quote to prevent globbing and word splitting.
* Added double quotes
scripts/wireguard/disableCONF.sh
* Mapfile instead of double quoted LIST=("$(...)")
scripts/wireguard/enableCONF.sh
* SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
* Disabled warning
* SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
* Changed to mapfile
* SC2086: Double quote to prevent globbing and word splitting.
* Added double quotes
scripts/openvpn/removeOVPN.sh
* SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
* Disabled warning
* SC2128: Expanding an array without an index only gives the first element.
* Disabled warning, as its only checking if variable is empty
* SC2001: See if you can use ${variable//search/replace} instead.
* Disabled warning, regex doesn't apply to ${variable//search/replace}
* SC2086: Double quote to prevent globbing and word splitting.
* Added double quotes
* SC2140: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"?
* Removed unecessary double quotes from %s
* SC2154: <VariableName> is referenced but not assigned.
* Disabled warning, variables sourced externally
scripts/openvpn/pivpnDebug.sh
* SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
* Disabled warning message
* SC2154: <VariableName> is referenced but not assigned.
* Disabled warning message
* SC2086: Double quote to prevent globbing and word splitting.
* Added double quotes
* SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
* Added double quotes
scripts/openvpn/makeOVPN.sh
* SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
* Disabled warning
* SC2086: Double quote to prevent globbing and word splitting.
* Added missing double quotes
* SC2001: See if you can use ${variable//search/replace} instead.
* Disabled warning, suggested method doesn't go well with regexp
* SC2154: <VarName> is referenced but not assigned.
* Disabled warning, variables are sourced externally and may differ
shellchek job not exiting with propper error code due to find -exec exit
code be always 0.
Piping find to xargs instead to get propper exit codes from shellcheck
scripts/uninstall.sh
* SC2154: <VarName> is referenced but not assigned.
* Disabled warnings for mentioned errors as they are sourced externaly and may vary
scripts/self_check.sh
* Fixes SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
* SC2154: <VarName> is referenced but not assigned.
* Disabled warnings for the mentioned errors as they are sourced externaly and may vary
* Introduction to Github discussions
* Added pivpn room at matrix.org
* Changed titles format from -- to ##
* (tried) to make readme a bit more clear in regards opening
issues and bug reports
debconf-apt-progress is a tool to show a whiptail based dialog with progress bar for apt package installs, but it is some downsides:
- It aborts whenever apt or debconf halt for an interactive input, hence this would need to be prevented carefully, e.g. via "DEBIAN_FRONTEND=noninteractive" and "--force-confdef/old/new/miss", while it is questionable whether PiVPN should mute such configuration inputs for users.
- It even aborts when such interactive input is not actually required in some cases, but triggered by some other debconf load internals: pivpn#1360
Most importantly, aside of the visually probably appealing progress bar, debconf-apt-progress has not any upsides but reduces transparency of what is actually done, and the installer has a fallback already.
This commit removes the debconf-apt-progress usage in favour of the fallback: direct apt-get usage.
Signed-off-by: MichaIng <micha@dietpi.com>
